Rspec 3 and 2 compatibility #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 24, 2014 11:21
…ec3_test Conflicts: lib/rspec-puppet/matchers/run.rb
…ec3_test Conflicts: lib/rspec-puppet/matchers/run.rb
| @@ -12,7 +12,7 @@ module ManifestMatchers | |||
| "include Class[#{expected_class}]" | |||
| end | |||
|
|
|||
| failure_message_for_should do |actual| | |||
| failure_message do |actual| | |||
There was a problem hiding this comment.
We'll probably need to alias failure_message to failure_message_for_should here
added 6 commits
September 24, 2014 15:32
move the rspec2 catcher to support.rb
- add newer ruby version - add new puppet version - add rspec2 - exclude new puppet on old ruby
|
Looks good to me 👍 Any progress on getting this merged and shipped? I'm starting a new module and would love to start the test suite off against RSpec 3 and save the pain of an upgrade down the road. |
|
@rodjek I have finished the work on rspec2/3 compatibility and have added some more tests. Please let me know whether you see stuff which needs to get changed. |
This was referenced Oct 30, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecation warnings on
But still keeping RSpec 2 functional