✨ Improve Makefile compile speed #123

Jerrylum · 2019-02-21T16:43:34Z

Summary:

Someone doesn't want to waste his time. So he adds this code to make compile-job faster. The compiler now doesn't need to remove and create temp.log every time it compiles a file.

Motivation:

Add it.

References (optional):

close #103

Test Plan:

edjubuh

Smart to change to test -s. Good catch to improve speed.

common.mk

🎉

Jerrylum · 2019-02-22T04:49:58Z

Faster than my idea 3 seconds! But I got an error when I compile with 🔥/❄️ linking

edjubuh · 2019-02-25T19:59:57Z

I think it might be processing C:\Program Files\PROS\toolchain\usr\... with escape characters (e.g. \t as a tab). Need to figure out how to make sure /bin/sh or printf doesn't do that (not sure who's processing it as an escaped character)

HotelCalifornia · 2019-02-25T20:05:25Z

/bin/sh: line 0: printf: missing Unicode digit for \u

Looks like it's printf, but does that explain it not finishing compilation?

edjubuh · 2019-02-25T20:15:23Z

Looks like it's printf, but does that explain it not finishing compilation?

I think so. Either way, it must be addressed

I will try it after dinner

HotelCalifornia · 2019-02-26T15:25:22Z

tested changes to common.mk in a new project on macOS. everything seems to work ok, and color printing works now.

before:

Building project...
-n Compiling src/autonomous.cpp
-e \x1b[32;01m[OK]\x1b[0m
-n Compiling src/initialize.cpp
-e \x1b[32;01m[OK]\x1b[0m
-n Compiling src/opcontrol.cpp
-e \x1b[32;01m[OK]\x1b[0m
-n Adding timestamp
-e \x1b[32;01m[OK]\x1b[0m
-n Linking project with libpros,okapilib
-e \x1b[32;01m[OK]\x1b[0m
Section sizes:
   text	   data	    bss	  total	    hex	filename
 440895	   3216	49897144	50341255	3002587	bin/monolith.elf
-n Creating bin/monolith.bin for VEX EDR V5
-e \x1b[32;01m[DONE]\x1b[0m

after:

Cleaning project
Compiled src/autonomous.cpp [OK]
Compiled src/initialize.cpp [OK]
Compiled src/opcontrol.cpp [OK]
Adding timestamp [OK]
Linking project with libpros,okapilib [OK]
Section sizes:
   text	   data	    bss	  total	    hex	filename
 440895	   3216	49897144	50341255	3002587	bin/monolith.elf
Creating bin/monolith.bin for VEX EDR V5 [DONE]
Capturing metadata for PROS Editor...

HotelCalifornia · 2019-02-26T15:26:32Z

common.mk

 	-$(VV)$(SIZETOOL) $(SIZEFLAGS) $@ $(SIZES_SED) $(SIZES_NUMFMT)

 define asm_rule
 $(BINDIR)/%.$1.o: $(SRCDIR)/%.$1
 	$(VV)mkdir -p $$(dir $$@)
-	@echo -n "Compiling $$< "
-	$$(call test_output,$D$(AS) -c $(ASMFLAGS) -o $$@ $$<,$(OK_STRING))
+	$$(call test_output_2,Compiled $$< ,$(AS) -c $(ASMFLAGS) -o $$@ $$<,$(OK_STRING))


is there a reason these changed from "Compiling" to "Compiled"? (lines 242 and 249 as well)

The text is displayed after the file is compiled, not before.

sure, but the way the line is laid out, compiling <filename> <completion status> makes more sense, doesn't it? to say something "compiled" (I think) implies that it was completed successfully. small nit, but I don't really see a need for this change from a UX perspective

Jerrylum · 2019-02-26T16:26:16Z

The latest version is slower than the older version about 2 seconds. I think the compile speed is depending on Hard Drive speed but that's very embarrassing. 😕

edjubuh · 2019-02-27T16:38:27Z

The latest version is slower than the older version about 2 seconds. I think the compile speed is depending on Hard Drive speed but that's very embarrassing. 😕

You sure? I really only added another shell variable and un-escaped the printfs.

HotelCalifornia

👍

#### Summary: Migrate kernel makefile to `test_output_2` and make make make again. #### Motivation: It's broken because `@cd` isn't a command. `@` was supposed to suppress echoing the whole command, but `test_output` has changed. ##### References (optional): #123 #### Test Plan: - [X] It build

@kdcrafter

* Better errno for registry validation failure, update vision sensor errnos Summary: - Changed port number validation to return ENXIO when outside the domain of port numbers - Changed port validation to return ENODEV when the requested device doesn't match the actual device - Vision Sensor read/get functions consistently use EAGAIN when the libv5rts tells us it couldn't get data - Remove docstrings for EACCES since it is practically impossible to get that errno (we wait for mutex indefinitely) Test Plan: TBD * ✨ Add Makefile-variable for excluding libraries from cold image (#121) #### Summary: Someone want to enable 🔥/❄ function but he doesn't want to include all libraries in the cold image. So he adds this feature here. you can edit `EXCLUDE_COLD_LIBRARIES` to exclude the library. The library will be compiled every time you use `make` command. (🔥🔥🔥) #### Motivation: Add it. ##### References (optional): lazy to make an issue. 404 not found. #### Test Plan: - [x] Make a library for testing - [x] Make a new project and apply the testing library - [x] Compile with 🔥/❄ function (use `make all`) - [x] Upload and test if the library is running? - [x] Exclude the library - [x] Compile with 🔥/❄ function (use `make all`) - [x] Upload and test if the library is running? - [x] Change something in the project - [x] Compile with 🔥/❄ function (use `make`) - [x] Upload and test if the library is running? - [x] delete variable `EXCLUDE_COLD_LIBRARIES` - [x] Compile with 🔥/❄ function (use `make all`) - [x] Upload and test if the library is running? * Update vdml_vision.c * Update vdml_vision.c * Update vdml_vision.c * Update Copyright info to current year * 🐛 Fix cold libraries variable assignment (#129) * Apply suggestions from code review Co-Authored-By: edjubuh <[email protected]> * Fix whitespace * Fix up errno when mismatch/not connected * Fix up errno when mismatch/not connected for ADI * Fix up errno when mismatched/not connected for ADI round 2 * Fix up errno when mismatched/not connected for ADI round 3 * ✨ Improve Makefile compile speed (#123) #### Summary: Someone doesn't want to waste his time. So he adds this code to make compile-job faster. The compiler now doesn't need to remove and create `temp.log` every time it compiles a file. #### Motivation: Add it. ##### References (optional): close #103 #### Test Plan: - [x] Call `make all` - [x] Call `make` - [x] Try to compile with no error - [x] Try to compile with warning - [x] Try to compile with error #### Commits: * ✨ Improve Makefile compile speed * Use only variables; use printf * Keep changes from #119 * Do not treat strings as escaped * Migate kernel makefile to test_output_2 (#130) #### Summary: Migrate kernel makefile to `test_output_2` and make make make again. #### Motivation: It's broken because `@cd` isn't a command. `@` was supposed to suppress echoing the whole command, but `test_output` has changed. ##### References (optional): #123 #### Test Plan: - [X] It build * Fix incorrect port type (#139) #### Summary: Fix incorrect port type in some motor functions #### Motivation: They were different from everywhere else with seemingly no reason. #### Test Plan: - [x] Still compiles * Add alternate generic serial API and fix generic serial filesystem driver (#141) * Add alternate serial API * Fix generic serial files * Add serial tests * Fix dev_read_r and dev_write_r starving tasks * Revert DEVCTL_SET_BAUDRATE to maintain compatibility * Update generic serial test * Modify blocking serial sleep time * Move serial include * Change serial telemetry function names * 🐛 Update vision_read_by_sig to be less funky (#124) * Update vision_read_by_sig to properly transform all coordinates and respect array boundaries Summary: - We weren't properly respecting array boundaries on read_by_sig, now we are Test Plan: - [x] @kdcrafter tested in T659 and throughout Worlds * Update vdml_vision.c * 🚨 Make things work with GCC 8.3 (#155) * add __sync_synchronize stub * catch exception by reference to suppress new warning * move mlock functions to their own file to fix newlib * 🔧 Enable hot/cold by default (#154) * 🏗 Combine template source files (#152) * Rename main.c to startup.c * Combine initialize, autonomous, and opcontrol into main * Patch Makefile * Patch template-Makefile * Don't change USE_PACKAGE in this PR * 🐛 Fix multiple ADI bugs and inconsistencies (#151) * Fix IntelliSense error * Note possible hack with registry pad * Note possible issue with claim_port * Cleanup ADI C API * Remove config clear from ADI destructor * Move ADI config to initilizer list * Fix double normalization of ultrasonic port * Partially Revert "Remove config clear from ADI destructor" This partially reverts commit 6a562ef. * Declare ADIPort destructor as default * Revert "Note possible hack with registry pad" This reverts commit 866067b. * Change claim_port note * ⬆️ Upgrade LVGL to 5.3 (#144) * [wip] rollback point * finish upgrade\? doubt it * update lv_conf * make everything compile - still need to test for some regressions - still need to test some 5.3 features * initialize LVGL before system daemon * make non-monospaced font the default again * limit LLEMU screen to 33 monospace chars * clean versions * add comment about system_daemon_initialize * 🤫 Suppress ignored qualifiers when including lvgl (#147) * 🔧 Add default `.gitignore` to template (#156) * 🚸 Add alternate constructor for pros::Task (#158) * Alternate Task contructor: ommission of prio and stack_depth while still allowing access to name * Delegation of truncated constructor to the normal constructor * 💚 Update toolchain installation for azure (#163) * update toolchain installation for azure the PPA was hanging, and it installs an old version anyway * Update azure-pipelines.yml Co-Authored-By: Elliot Berman <[email protected]> * 🚨🔊 Add a better Data Abort Handler (#112) * Add WIP of a better DataAbortHandler * More WIP * Cleanup * refactor some things * Refactor, clean up, and documentation * More comments * Update unwind.c * Tweak printfs * Add custom build of newlib * Include libc/libm in template * Exclude libc/libm from being included in cold image * check whether pc is in the hot zone * test unwind with hot/cold linking * Add support for unwinding through hot code * Clean up for PR * Undo USE_PACKAGE:=1 * remove leftover include * move __env_lock/__env_unlock to src/system/envlock.c missed this in #155, but these two functions are moved to their own file for the same reason as __malloc_lock/__malloc_unlock were-- to follow the override scheme that newlib expects. found the right filename from here: https://newlib.sourceware.narkive.com/aXWplROp/queries-concerning-rtos-protection-in-newllib * lint files * Update .arclint whitespace * 🐛 Add default LLEMU init code back to main.cpp (#165) * 🐛 adddefault LLEMU init code back to main.cpp * add documentation comment for callback function * Bump to 3.2.0 * 🔧 Recompile on header change (#167) * implemented header dependency tracking * Added dependency folder to the makefile * fix bug in making c folders * Renamed POSTCOMPILE * Undo unwanted changes * Modify template gitignore * Ignore clean errors * 🐛 Return proper error code for VDML functions that return floating point numbers (#160) * 🐛 Fix problem of return PROS_ERR_F error code * 🐛 Improve condition statement and comment VDML function 🤫 forgot to change * 🐛 Undo claim_port_try code to avoid warning 🐛 Undo claim_port_try code to avoid warning * 🐛 Fix motor PID functions bug (#162)

✨ Improve Makefile compile speed

c587bfa

edjubuh reviewed Feb 21, 2019

View reviewed changes

common.mk Outdated Show resolved Hide resolved

edjubuh and others added 3 commits February 21, 2019 20:03

Use only variables; use printf

d1b50af

Keep changes from #119

13fe260

Merge pull request #1 from purduesigbots/feature/improve-compile-speed

13e9ee3

🎉

edjubuh added this to the 3.1.7 milestone Feb 26, 2019

edjubuh and others added 2 commits February 26, 2019 10:11

Do not treat strings as escaped

35acb68

Merge pull request #2 from purduesigbots/feature/improve-compile-speed

dfcd035

I will try it after dinner

HotelCalifornia reviewed Feb 26, 2019

View reviewed changes

HotelCalifornia added p: normal Normal priority enhancement This builds on top of an existing feature in progress This is currently being worked on labels Mar 4, 2019

HotelCalifornia approved these changes Mar 11, 2019

View reviewed changes

edjubuh merged commit 021f8be into purduesigbots:develop Mar 11, 2019

edjubuh mentioned this pull request Mar 11, 2019

Migate kernel makefile to test_output_2 #130

Merged

1 task

HotelCalifornia mentioned this pull request Sep 3, 2019

🔖 Release 3.2.0 #166

Merged

1 task

HotelCalifornia mentioned this pull request Jan 23, 2020

Expand macOS getting started page purduesigbots/pros-docs#86

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Improve Makefile compile speed #123

✨ Improve Makefile compile speed #123

Jerrylum commented Feb 21, 2019 •

edited

Loading

edjubuh left a comment

Jerrylum commented Feb 22, 2019

edjubuh commented Feb 25, 2019

HotelCalifornia commented Feb 25, 2019

edjubuh commented Feb 25, 2019

HotelCalifornia commented Feb 26, 2019

HotelCalifornia Feb 26, 2019

edjubuh Feb 26, 2019

HotelCalifornia Feb 26, 2019 •

edited

Loading

Jerrylum commented Feb 26, 2019

edjubuh commented Feb 27, 2019

HotelCalifornia left a comment

✨ Improve Makefile compile speed #123

✨ Improve Makefile compile speed #123

Conversation

Jerrylum commented Feb 21, 2019 • edited Loading

Summary:

Motivation:

References (optional):

Test Plan:

edjubuh left a comment

Choose a reason for hiding this comment

Jerrylum commented Feb 22, 2019

edjubuh commented Feb 25, 2019

HotelCalifornia commented Feb 25, 2019

edjubuh commented Feb 25, 2019

HotelCalifornia commented Feb 26, 2019

HotelCalifornia Feb 26, 2019

Choose a reason for hiding this comment

edjubuh Feb 26, 2019

Choose a reason for hiding this comment

HotelCalifornia Feb 26, 2019 • edited Loading

Choose a reason for hiding this comment

Jerrylum commented Feb 26, 2019

edjubuh commented Feb 27, 2019

HotelCalifornia left a comment

Choose a reason for hiding this comment

Jerrylum commented Feb 21, 2019 •

edited

Loading

HotelCalifornia Feb 26, 2019 •

edited

Loading