-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken fault reporting #1
Conversation
Pixel thank you for discovering this! I will be sure to validate your changes as soon as my cortex is delivered to merge this change in before the beta ends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
@@ -49,7 +49,7 @@ void __attribute__((noreturn)) _exit(int status) { | |||
} | |||
// Dump message | |||
if ((unsigned int)status < 5U) { | |||
buffer = (const char *)&errorMessages[status]; | |||
buffer = errorMessages[status]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great!
Also, we'll merge this onto the 2.11.1 branch, not master. |
No more last missing character
* Create ISSUE_TEMPLATE.md * Create PULL_REQUEST_TEMPLATE.md * Create CONTRIBUTING.md
#### Summary: Add Azure Pipelines for building templates #### Motivation: It'd be nice to have standard CI builds of the kernel ##### References (optional): <!-- If this PR is related to an issue or task, reference it here (e.g. closes #1) --> #### Test Plan: - [x] It build
#### Summary: ``` make template make ``` would cause the version to be updated to a dirty commit version, which would then get set as the build number (despite being a commit build) This change does ``` make template (Update Build number) make ``` #### Motivation: So that we don't see a dirty version ##### References (optional): <!-- If this PR is related to an issue or task, reference it here (e.g. closes #1) --> #### Test Plan: - [x] Look at Pipeline build number ![image](https://user-images.githubusercontent.com/5461357/52889533-70220a80-314e-11e9-9972-1342bb7303a2.png) #### Commits: * Re-order make execution after updating build number So that we don't see a dirty version * Try including PR ID in version * print environ * Fix it
Before the faults would show up as an invalid string, now they work
example code:
before:
after:
kinda.. the last character isn't coming through
explanation:
errorMessages[status] is of type const char*
&errorMessages[status] gets a reference to the temp variable used to store the const char*
(const char*) bypasses type safety so this mistake causes no compiler errors
the raw bytes of the pointer to errorMessages[status] are sent to USART instead of the contents of errorMessages[status]