🐛 Return proper error code for VDML functions that return floating point numbers

[Jerrylum]

Summary:

Someone is very lazy. Use claim_port in all functions.

Modify claim_port(port, device_type) to claim_port(port, device_type, error_code)
Add claim_port_i(port, device_type) for int32_t function
Add claim_port_f(port, device_type) for double and float function
Modify claim_port_try, return 1 if success, else 0(It was return PROS_ERR)

Motivation:

Love, Harry, Love.

References (optional):

closes #159

Test Plan:

• Compile
• Run template file code (as it makes motors move)
• Run test/generic_serial.cpp
• Run test/vision_test.cpp
• Use on your robot. (as it tests 80% motor functions and give you a heart attack)

[HotelCalifornia]

I can't compile the files
I don't know what to do.

please come up with a small set of ways that those of us who can compile the code can use verify this change has been made correctly

[HotelCalifornia]

some minor things. notably, I'd prefer if you didn't refer explicitly to true or false when checking the output of claim_port_try because it doesn't return a strict bool (i.e. from stdbool.h), rather it uses the convention that 0 is falsey and nonzero values are truthy.

[baylessj]

Looks good to me, I'll approve when it can get compiled and run with a test plan

[Jerrylum]

some minor things. notably, I'd prefer if you didn't refer explicitly to true or false when checking the output of claim_port_try because it doesn't return a strict bool (i.e. from stdbool.h), rather it uses the convention that 0 is falsey and nonzero values are truthy.

I pushed a new commit and it should fix what you said. Notice me if any problem.
Also, I am trying to make a Test Plan for you. just wait a minute.

[HotelCalifornia]

you're going to also need to look at src/vdml_adi.c, as the signature for claim_port has now changed.

[Jerrylum]

you're going to also need to look at src/vdml_adi.c, as the signature for claim_port has now changed.

I changed all of them to claim_port_i in the vdml_adi.c. Also, I had a fully files search in the repo and replaced the signature one by one. So I think it is fine.

[HotelCalifornia]

you're going to also need to look at src/vdml_adi.c, as the signature for claim_port has now changed.

I changed all of them to claim_port_i in the vdml_adi.c. Also, I had a fully files search in the repo and replaced the signature one by one. So I think it is fine.

Ah yep, so you did. my bad

[HotelCalifornia]

/AzurePipelines run