Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Release 3.2.0 #166

Merged
merged 37 commits into from
Sep 15, 2019
Merged

🔖 Release 3.2.0 #166

merged 37 commits into from
Sep 15, 2019

Conversation

HotelCalifornia
Copy link
Contributor

@HotelCalifornia HotelCalifornia commented Sep 3, 2019

Summary:

Special thanks to @Jerrylum, @TixoRebel, @Octogonapus, @theol0403, and @SpencerJ21 for their contributions!

Motivation:

We've been accumulating changes since February, and have finally cleared the 3.2.0 milestone (formerly known as 3.1.7)!

Why bump to 3.2.0 instead of going with 3.1.7? This release includes some potentially breaking changes, like rearranging errno values and the update to LVGL 5.3.

References (optional):

See summary

Test Plan:

  • features were tested in their respective PRs

edjubuh and others added 30 commits January 30, 2019 14:18
…rnos

Summary:
  - Changed port number validation to return ENXIO when outside the domain of port numbers
  - Changed port validation to return ENODEV when the requested device doesn't match the actual device
  - Vision Sensor read/get functions consistently use EAGAIN when the libv5rts tells us it couldn't get data
  - Remove docstrings for EACCES since it is practically impossible to get that errno (we wait for mutex indefinitely)

Test Plan:
TBD
#### Summary:
Someone want to enable 🔥/❄ function but he doesn't want to include all libraries in the cold image. So he adds this feature here. you can edit `EXCLUDE_COLD_LIBRARIES` to exclude the library. The library will be compiled every time you use `make` command. (🔥🔥🔥)

#### Motivation:
Add it.

##### References (optional):
lazy to make an issue. 404 not found.

#### Test Plan:
- [x] Make a library for testing
- [x] Make a new project and apply the testing library
- [x] Compile with  🔥/❄ function (use `make all`)
- [x] Upload and test if the library is running?
- [x] Exclude the library
- [x] Compile with  🔥/❄ function (use `make all`)
- [x] Upload and test if the library is running?
- [x] Change something in the project
- [x] Compile with  🔥/❄ function  (use `make`)
- [x] Upload and test if the library is running?
- [x] delete variable `EXCLUDE_COLD_LIBRARIES`
- [x] Compile with  🔥/❄ function (use `make all`)
- [x] Upload and test if the library is running?
📝 Update Copyright info to current year
#### Summary:
Someone doesn't want to waste his time. So he adds this code to make compile-job faster. The compiler now doesn't need to remove and create `temp.log` every time it compiles a file. 

#### Motivation:
Add it.

##### References (optional):
close #103 

#### Test Plan:
- [x] Call `make all`
- [x] Call `make`
- [x] Try to compile with no error
- [x] Try to compile with warning
- [x] Try to compile with error

#### Commits:

* ✨ Improve Makefile compile speed

* Use only variables; use printf

* Keep changes from #119

* Do not treat strings as escaped
#### Summary:
Migrate kernel makefile to `test_output_2` and make make make again.

#### Motivation:
It's broken because `@cd` isn't a command. `@` was supposed to suppress echoing the whole command, but `test_output` has changed.

##### References (optional):
#123 

#### Test Plan:
- [X] It build
#### Summary:
Fix incorrect port type in some motor functions

#### Motivation:
They were different from everywhere else with seemingly no reason.

#### Test Plan:

- [x] Still compiles
…iver (#141)

* Add alternate serial API

* Fix generic serial files

* Add serial tests

* Fix dev_read_r and dev_write_r starving tasks

* Revert DEVCTL_SET_BAUDRATE to maintain compatibility

* Update generic serial test

* Modify blocking serial sleep time

* Move serial include

* Change serial telemetry function names
* Update vision_read_by_sig to properly transform all coordinates and
respect array boundaries

Summary:
- We weren't properly respecting array boundaries on read_by_sig, now we
are

Test Plan:
- [x] @kdcrafter tested in T659 and throughout Worlds

* Update vdml_vision.c
Summary
  - Changed port number validation to return ENXIO when outside the domain of port numbers
  - Changed port validation to return ENODEV when the requested device doesn't match the actual device
  - Vision Sensor read/get functions consistently use EAGAIN when the libv5rts tells us it couldn't get data
  - Remove docstrings for EACCES since it is practically impossible to get that errno (we wait for mutex indefinitely)
  - vision_get_by_sig consistently sets errno to EDOM when unable to find objects that match (valid) arguments

Right now, our returned errnos aren't that great.

Close #117

- [X] When objects are in vision sensors FOV, but none are of a particular signature, signature ID is correct and EDOM is errno

```cpp
errno = 0; // set to 0 to make sure errno is being set properly... normally wouldn't do this
// errno was 33 b/c there were no objects to see of signature 1
pros::lcd::print(1, "%d (%d)", vision.get_by_sig(0, 1).signature, errno);
errno = 0;
// errno was 0 b/c it worked fine
pros::lcd::print(2, "%d (%d)", vision.get_by_sig(0, 2).signature, errno);
errno = 0;
// errno was flickered between 0/33 b/c there were sometimes objects of 2 to see
pros::lcd::print(3, "%d (%d)", vision.get_by_sig(2, 2).signature, errno);
errno = 0;
// errno was EINVAL (22) because 8 is an invalid signature id
pros::lcd::print(4, "%d (%d)", vision.get_by_sig(8, 2).signature, errno);
errno = 0;
// errno was EADDRINUSE (112) b/c there was a radio plugged in
pros::lcd::print(5, "%d (%d)", pros::c::vision_get_by_sig(21, 0, 1).signature, errno);
errno = 0;
// errno was ENXIO (6) b/c there's no smart port #22
pros::lcd::print(6, "%d (%d)", pros::c::vision_get_by_sig(22, 0, 1).signature, errno);
// errno was ENODEV (19) b/c there's no motor plugged into 2 (or anything for that matter)
errno = 0;
pros::lcd::print(7, "%d (%d)", pros::c::motor_get_voltage(2), errno);
```
* add __sync_synchronize stub

* catch exception by reference to suppress new warning

* move mlock functions to their own file to fix newlib
* Rename main.c to startup.c

* Combine initialize, autonomous, and opcontrol into main

* Patch Makefile

* Patch template-Makefile

* Don't change USE_PACKAGE in this PR
* Fix IntelliSense error

* Note possible hack with registry pad

* Note possible issue with claim_port

* Cleanup ADI C API

* Remove config clear from ADI destructor

* Move ADI config to initilizer list

* Fix double normalization of ultrasonic port

* Partially Revert "Remove config clear from ADI destructor"

This partially reverts commit 6a562ef.

* Declare ADIPort destructor as default

* Revert "Note possible hack with registry pad"

This reverts commit 866067b.

* Change claim_port note
* [wip] rollback point

* finish upgrade\? doubt it

* update lv_conf

* make everything compile

- still need to test for some regressions
- still need to test some 5.3 features

* initialize LVGL before system daemon

* make non-monospaced font the default again

* limit LLEMU screen to 33 monospace chars

* clean versions

* add comment about system_daemon_initialize
* Alternate Task contructor: ommission of prio and stack_depth while still allowing access to name

* Delegation of truncated constructor to the normal constructor
HotelCalifornia and others added 4 commits September 1, 2019 04:21
* update toolchain installation for azure

the PPA was hanging, and it installs an old version anyway

* Update azure-pipelines.yml

Co-Authored-By: Elliot Berman <[email protected]>
* Add WIP of a better DataAbortHandler

* More WIP

* Cleanup

* refactor some things

* Refactor, clean up, and documentation

* More comments

* Update unwind.c

* Tweak printfs

* Add custom build of newlib

* Include libc/libm in template

* Exclude libc/libm from being included in cold image

* check whether pc is in the hot zone

* test unwind with hot/cold linking

* Add support for unwinding through hot code

* Clean up for PR

* Undo USE_PACKAGE:=1

* remove leftover include

* move __env_lock/__env_unlock to src/system/envlock.c

missed this in #155, but these two functions are moved to their own file for the same reason as __malloc_lock/__malloc_unlock were-- to follow the override scheme that newlib expects. found the right filename from here: https://newlib.sourceware.narkive.com/aXWplROp/queries-concerning-rtos-protection-in-newllib

* lint files

* Update .arclint whitespace
* 🐛 adddefault LLEMU init code back to main.cpp

* add documentation comment for callback function
@HotelCalifornia HotelCalifornia added the release PR for a new release label Sep 3, 2019
@HotelCalifornia HotelCalifornia self-assigned this Sep 3, 2019
@HotelCalifornia
Copy link
Contributor Author

waiting on documentation

@HotelCalifornia HotelCalifornia changed the title Release/3.2.0 🔖 Release 3.2.0 Sep 3, 2019
@HotelCalifornia
Copy link
Contributor Author

HotelCalifornia commented Sep 5, 2019

also waiting on late additions: #160 and #162

nathan-moore and others added 2 commits September 12, 2019 15:58
* implemented header dependency tracking

* Added dependency folder to the makefile

* fix bug in making c folders

* Renamed POSTCOMPILE

* Undo unwanted changes

* Modify template gitignore

* Ignore clean errors
…int numbers (#160)

* 🐛 Fix problem of return PROS_ERR_F error code

* 🐛 Improve condition statement and comment VDML function


🤫 forgot to change

* 🐛 Undo claim_port_try code to avoid warning




🐛 Undo claim_port_try code to avoid warning
@HotelCalifornia HotelCalifornia added this to the 3.2.0 milestone Sep 12, 2019
@Octogonapus
Copy link
Contributor

@HotelCalifornia Ready for final review?

@HotelCalifornia HotelCalifornia marked this pull request as ready for review September 15, 2019 01:31
Copy link
Contributor

@baylessj baylessj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HotelCalifornia HotelCalifornia merged commit ab99a33 into master Sep 15, 2019
@HotelCalifornia HotelCalifornia deleted the release/3.2.0 branch September 13, 2020 07:37
@HotelCalifornia HotelCalifornia restored the release/3.2.0 branch September 13, 2020 07:38
@HotelCalifornia HotelCalifornia deleted the release/3.2.0 branch September 13, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release PR for a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants