Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll out PULUMI_CONVERT=1 to tier 2 providers #889

Closed
67 tasks done
Tracked by #1280
t0yv0 opened this issue Apr 16, 2024 · 11 comments · Fixed by pulumi/pulumi-digitalocean#710
Closed
67 tasks done
Tracked by #1280

Roll out PULUMI_CONVERT=1 to tier 2 providers #889

t0yv0 opened this issue Apr 16, 2024 · 11 comments · Fixed by pulumi/pulumi-digitalocean#710
Assignees
@t0yv0
Labels
kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Apr 16, 2024 •
edited
Loading

Bridged Providers

Tier 1

  • aws
  • gcp
  • azure
  • azuread

Tier 2
This was referenced Apr 16, 2024
Closed
Closed
@t0yv0 t0yv0 self-assigned this Apr 16, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 16, 2024

@pulumi/providers hi team if you can help me getting these reviewed I'll appreciate it very much. Most are fairly mechanical but if you spot something odd it's worth discussing.

@VenelinMartinov
Copy link
Contributor

Spotted a few possible regressions:

Another possible regression: pulumi/pulumi-archive#182

Some here too: https://github.com/pulumi/pulumi-artifactory/pull/698/files
AlpineRepository is dropped because of terraform in the resource name - should we be renaming that?
DistributionPublicKey is dropped and I can't see why.

https://github.com/pulumi/pulumi-civo/pull/463/files
This one also has some

https://github.com/pulumi/pulumi-cloudflare/pull/735/files too

https://github.com/pulumi/pulumi-github/pull/640/files has some new examples but also some dropped ones

https://github.com/pulumi/pulumi-random/pull/890/files in RandomInteger.java has a
.action(%!v(PANIC=Format method: runtime error: invalid memory address or nil pointer dereference)) - this one seems odd? It's fine in non-Java sdks. Is this a panic which we printed in the example?

https://github.com/pulumi/pulumi-tls/pull/483/files drops a few examples too.

There seems to be a common theme I spotted in the dropped examples related to file operations perhaps? (edited)

@mikhailshilkov mikhailshilkov added the kind/task Work that's part of an ongoing epic label Apr 18, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

Some examples were dropped from missing std reference.

  • archive is addressed
  • artifactory is addressed
  • civo is addressed

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

cloudflare is addressed

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

tls is addressed

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

I'll spot-check GitHub, random. Still have some build problems in OCI.

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 19, 2024

Addressed it all. All ready to go!

Except for:

  • Random (blocked on panic rendered into Java example)
  • Digital Ocean (blocked on panic in convereter)

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 19, 2024

Per @mjeffryes merging the rest of unblocked PRs without waiting for approvals.

@t0yv0 t0yv0 mentioned this issue May 10, 2024
Merged
@t0yv0
Copy link
Member Author

t0yv0 commented May 10, 2024

Last one: pulumi/pulumi-digitalocean#710

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label May 13, 2024
@VenelinMartinov
Copy link
Contributor

Should we default enable this in the tf provider boilerplate too? @t0yv0

@t0yv0
Copy link
Member Author

t0yv0 commented May 13, 2024

Not needed when it becomes the default bridge behavior it will enable itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved Terraform examples converter pulumi/pulumi-digitalocean
4 participants
@t0yv0 @mikhailshilkov @VenelinMartinov @pulumi-bot