Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollout improved example converter #446

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Rollout improved example converter #446

merged 4 commits into from
Apr 18, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 16, 2024

Rolls out improved TF example converter.

@github-actions GitHub Actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@github-actions GitHub Actions
Copy link

Is README.md missing any configuration options?

assumeRole not found in Configuration section
awsAccessKeyId not found in Configuration section
awsSecretAccessKey not found in Configuration section
awsSessionToken not found in Configuration section
baseUrl not found in Configuration section
isMongodbgovCloud not found in Configuration section
realmBaseUrl not found in Configuration section
region not found in Configuration section
secretName not found in Configuration section
stsEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@t0yv0 t0yv0 mentioned this pull request Apr 16, 2024
Closed
67 tasks
VenelinMartinov
VenelinMartinov approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t0yv0 this provider looks like a big winner from the change

@VenelinMartinov VenelinMartinov merged commit c49cc5b into master Apr 18, 2024
18 checks passed
@VenelinMartinov VenelinMartinov deleted the t0yv0/rollout-converter branch April 18, 2024 17:39
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinMartinov VenelinMartinov VenelinMartinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t0yv0 @VenelinMartinov