Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout improved example converter #463

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Rollout improved example converter #463

merged 7 commits into from
Apr 19, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 16, 2024

Rolls out improved TF example converter.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

apiEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@VenelinMartinov
Copy link
Contributor

Dropped examples for Firewall and Sshkey

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 17, 2024

Another case of a missed std reference. Should be better now.

@t0yv0 t0yv0 requested review from VenelinMartinov and iwahbe April 17, 2024 15:50
@t0yv0 t0yv0 merged commit 51ed767 into master Apr 19, 2024
17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/rollout-converter branch April 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants