Rollout improved example converter #650
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Is README.md missing any configuration options?
Please add a description for each of these options to |
| @@ -31,72 +31,41 @@ namespace Pulumi.AliCloud.Cen | |||
| /// { | |||
| /// var config = new Config(); | |||
| /// var anotherUid = config.Get("anotherUid") ?? "xxxx"; | |||
| /// // Method 1: Use assume_role to operate resources in the target cen account, detail see https://registry.terraform.io/providers/aliyun/alicloud/latest/docs#assume-role | |||
There was a problem hiding this comment.
It looks like we are losing some valuable comments here. Does the converter not support comments?
| /// var bj = new AliCloud.Provider("bj", new() | ||
| /// { | ||
| /// Region = "cn-beijing", | ||
| /// }); | ||
| /// | ||
| /// var hz = new AliCloud.Provider("hz", new() | ||
| /// { | ||
| /// Region = "cn-hangzhou", | ||
| /// }); |
There was a problem hiding this comment.
We used to have multiple explicit providers here and we don't anymore? Any idea why?
There was a problem hiding this comment.
|
I saw two things I have questions about, but otherwise this looks good. |
t0yv0
force-pushed
the
t0yv0/rollout-converter
branch
from
031fc86 to
66df704
Compare
t0yv0
force-pushed
the
t0yv0/rollout-converter
branch
from
66df704 to
40cc608
Compare
Rolls out improved TF example converter.