Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout improved example converter #500

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 16, 2024

Rolls out improved TF example converter.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

No missing config!

@VenelinMartinov
Copy link
Contributor

Failing due to unrelated CI issues.

@t0yv0 t0yv0 mentioned this pull request Apr 17, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 17, 2024

Yes I filed them as a P1 in #502 - builds should be working all the time.

@t0yv0 t0yv0 force-pushed the t0yv0/rollout-converter branch from 425647b to c8e5426 Compare April 18, 2024 17:16
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some examples are dropped due to the file operations but otherwise looks good!

@VenelinMartinov VenelinMartinov merged commit 25f3382 into master Apr 18, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the t0yv0/rollout-converter branch April 18, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants