Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM: upgrade failed with event type truncate not valid #10282

Closed
GMHDBJD opened this issue Dec 12, 2023 · 2 comments · Fixed by #10380
Closed

DM: upgrade failed with event type truncate not valid #10282

GMHDBJD opened this issue Dec 12, 2023 · 2 comments · Fixed by #10380
Assignees
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/dm Issues or PRs related to DM. report/customer Customers have encountered this bug. severity/critical type/bug The issue is confirmed as a bug.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Dec 12, 2023

What did you do?

upgrade dm from v5.3.0 to v6.5.3

What did you expect to see?

upgrade succeed

What did you see instead?

upgrade failed with in binlog event filter: event type truncate not valid

Versions of the cluster

DM version (run dmctl -V or dm-worker -V or dm-master -V):

(paste DM version here, and you must ensure versions of dmctl, DM-worker and DM-master are same)

Upstream MySQL/MariaDB server version:

(paste upstream MySQL/MariaDB server version here)

Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

How did you deploy DM: tiup or manually?

(leave TiUP or manually here)

Other interesting information (system version, hardware config, etc):

>
>

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 12, 2023

before pingcap/tidb-tools#655, we not check event type failed, after this pr, we check the wrong event type, which will cause upgrade failed with wrong subtask config

@ti-chi-bot ti-chi-bot added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. and removed may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 labels Dec 20, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
close #10282
ti-chi-bot bot pushed a commit that referenced this issue Dec 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
close #10282
@jebter jebter removed the affects-7.6 label Jan 9, 2024
ti-chi-bot bot pushed a commit that referenced this issue Feb 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
close #10282
ti-chi-bot bot pushed a commit that referenced this issue Feb 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
close #10282
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. area/dm Issues or PRs related to DM. report/customer Customers have encountered this bug. severity/critical type/bug The issue is confirmed as a bug.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants