Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog-filter: log error instead of return it #10380

Merged
merged 2 commits into from
Dec 28, 2023
Merged

binlog-filter: log error instead of return it #10380

merged 2 commits into from
Dec 28, 2023

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Dec 28, 2023

What problem does this PR solve?

Issue Number: close #10282

What is changed and how it works?

log error instead of return it

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 28, 2023

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 28, 2023

/retest

lichunzhu
lichunzhu approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 28, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 28, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 28, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-28 08:33:48.274623045 +0000 UTC m=+1727519.311850046: ☑️ agreed by lichunzhu.
  • 2023-12-28 08:35:25.144281559 +0000 UTC m=+1727616.181508486: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit fdef38b into pingcap:master Dec 28, 2023
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #10381.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#10380
f7393a2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2023
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #10382.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#10380
6edcf12 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2023
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10383.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#10380
a1d6fb4 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10384.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#10380
3b0db43 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 28, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10385.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 28, 2023
@GMHDBJD @ti-chi-bot
This is an automated cherry-pick of pingcap#10380
2b0a30f 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
binlog-filter: log error instead of return it (#10380) (#10383)
e9d1010 
close #10282
ti-chi-bot bot pushed a commit that referenced this pull request Feb 20, 2024
@ti-chi-bot
binlog-filter: log error instead of return it (#10380) (#10385)
1252979 
close #10282
ti-chi-bot bot pushed a commit that referenced this pull request Feb 28, 2024
@ti-chi-bot
binlog-filter: log error instead of return it (#10380) (#10384)
a7eb240 
close #10282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM: upgrade failed with event type truncate not valid
4 participants
@GMHDBJD @ti-chi-bot @lance6716 @lichunzhu