Skip to content

Commit

Permalink
binlog-filter: log error instead of return it (#10380)
Browse files Browse the repository at this point in the history
close #10282
  • Loading branch information
GMHDBJD authored Dec 28, 2023
1 parent 8ca4b58 commit fdef38b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion dm/tests/all_mode/conf/dm-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ filters: # filter rules, mysql instance can ref rules in it
user-filter-1:
schema-pattern: "*" # pattern of the upstream schema name, wildcard characters (*?) are supported
table-pattern: "*" # pattern of the upstream table name, wildcard characters (*?) are supported
events: ["truncate table", "drop table"] # ignore truncate/drop table ddl
events: ["truncate table", "drop table", "truncate"] # ignore truncate/drop table ddl
action: Ignore

mydumpers:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ require (
github.com/pingcap/kvproto v0.0.0-20231204093812-96c40585233f
github.com/pingcap/log v1.1.1-0.20230317032135-a0d097d16e22
github.com/pingcap/tidb v1.1.0-beta.0.20231212043317-b478056bbf73
github.com/pingcap/tidb-tools v0.0.0-20231213042249-0e38c7873b5b
github.com/pingcap/tidb-tools v0.0.0-20231228035519-c4bdf178b3d6
github.com/pingcap/tidb/pkg/parser v0.0.0-20231212043317-b478056bbf73
github.com/prometheus/client_golang v1.17.0
github.com/prometheus/client_model v0.5.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -865,8 +865,8 @@ github.com/pingcap/sysutil v1.0.1-0.20230407040306-fb007c5aff21 h1:QV6jqlfOkh8hq
github.com/pingcap/sysutil v1.0.1-0.20230407040306-fb007c5aff21/go.mod h1:QYnjfA95ZaMefyl1NO8oPtKeb8pYUdnDVhQgf+qdpjM=
github.com/pingcap/tidb v1.1.0-beta.0.20231212043317-b478056bbf73 h1:mj3ewOCcI0z8NcE5KWCYmq8f+S+yeC77OuxSuLBU5sc=
github.com/pingcap/tidb v1.1.0-beta.0.20231212043317-b478056bbf73/go.mod h1:x3ROM4heOSAIf/nEVr9ac1+HfgkgydwQUrd8t5nFzjE=
github.com/pingcap/tidb-tools v0.0.0-20231213042249-0e38c7873b5b h1:1opGBN77UXGFCl3Tx5wiYTAn74pQ7yuwBkqRnSLxSHI=
github.com/pingcap/tidb-tools v0.0.0-20231213042249-0e38c7873b5b/go.mod h1:7m72uoBoTrr8JNNA7iFBH824j3clIJx34zlUWJ45Q6Y=
github.com/pingcap/tidb-tools v0.0.0-20231228035519-c4bdf178b3d6 h1:NJQd14hU0pLj8vS+vYtgFw4bXrFIXa/HfMdxALHtgVU=
github.com/pingcap/tidb-tools v0.0.0-20231228035519-c4bdf178b3d6/go.mod h1:7m72uoBoTrr8JNNA7iFBH824j3clIJx34zlUWJ45Q6Y=
github.com/pingcap/tidb/pkg/parser v0.0.0-20231212043317-b478056bbf73 h1:9+OZA39uCJe4x2zzkM6Uv+bp8/93Ggp0S+YvTSvs35E=
github.com/pingcap/tidb/pkg/parser v0.0.0-20231212043317-b478056bbf73/go.mod h1:yRkiqLFwIqibYg2P7h4bclHjHcJiIFRLKhGRyBcKYus=
github.com/pingcap/tipb v0.0.0-20230919054518-dfd7d194838f h1:NCiI4Wyu4GkViLGTu6cYcxt79LZ1SenBBQX1OwEV6Jg=
Expand Down

0 comments on commit fdef38b

Please sign in to comment.