binlog-filter: log error instead of return it (#10380) (#10385)

close #10282
pingcap · Feb 20, 2024 · 1252979 · 1252979
1 parent cef2753
commit 1252979
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dm/tests/all_mode/conf/dm-task.yaml b/dm/tests/all_mode/conf/dm-task.yaml
@@ -42,7 +42,7 @@ filters:                     # filter rules, mysql instance can ref rules in it
   user-filter-1:
     schema-pattern: "*"    # pattern of the upstream schema name, wildcard characters (*?) are supported
     table-pattern: "*"        # pattern of the upstream table name, wildcard characters (*?) are supported
-    events: ["truncate table", "drop table"]  # ignore truncate/drop table ddl
+    events: ["truncate table", "drop table", "truncate"]  # ignore truncate/drop table ddl
     action: Ignore
 
 mydumpers:

diff --git a/go.mod b/go.mod
@@ -69,7 +69,7 @@ require (
 	github.com/pingcap/kvproto v0.0.0-20230925123611-87bebcc0d071
 	github.com/pingcap/log v1.1.1-0.20230317032135-a0d097d16e22
 	github.com/pingcap/tidb v1.1.0-beta.0.20231010115255-ec2731b8f539
-	github.com/pingcap/tidb-tools v0.0.0-20231010140451-6189b1bea2fd
+	github.com/pingcap/tidb-tools v0.0.0-20240220032153-0792ce9410ca
 	github.com/pingcap/tidb/parser v0.0.0-20231010115255-ec2731b8f539
 	github.com/prometheus/client_golang v1.16.0
 	github.com/prometheus/client_model v0.4.0

diff --git a/go.sum b/go.sum
@@ -1047,8 +1047,8 @@ github.com/pingcap/sysutil v1.0.1-0.20230407040306-fb007c5aff21/go.mod h1:QYnjfA
 github.com/pingcap/tidb v1.1.0-beta.0.20220511160835-98c31070d958/go.mod h1:luW4sIZoLHY3bCWuKqyqk2QgMvF+/M7nWOXf/me0+fY=
 github.com/pingcap/tidb v1.1.0-beta.0.20231010115255-ec2731b8f539 h1:Pw+tqB5BeNxn8uRQh6XZgU/MmdaSQiXtioStsxiu7M4=
 github.com/pingcap/tidb v1.1.0-beta.0.20231010115255-ec2731b8f539/go.mod h1:K9GzvaQZ9ht52B81kDXqvtW8p5rkQmP8rgJ8AW8yXCo=
-github.com/pingcap/tidb-tools v0.0.0-20231010140451-6189b1bea2fd h1:0BfNSfxiQgTD+YA4a3dmb7zR7nyVMOZB4qknn1y8t9s=
-github.com/pingcap/tidb-tools v0.0.0-20231010140451-6189b1bea2fd/go.mod h1:Awem9vQiEdvfdGLEbO6HWjR1jh2vFOCjKkwZdoHXfVI=
+github.com/pingcap/tidb-tools v0.0.0-20240220032153-0792ce9410ca h1:OLk9PSGTMsDoUGoafyNaXwzljaNJGZZtU2f/JYP2v8M=
+github.com/pingcap/tidb-tools v0.0.0-20240220032153-0792ce9410ca/go.mod h1:Awem9vQiEdvfdGLEbO6HWjR1jh2vFOCjKkwZdoHXfVI=
 github.com/pingcap/tidb/parser v0.0.0-20211011031125-9b13dc409c5e/go.mod h1:e1MGCA9Sg3T8jid8PKAEq5eYVuMMCq4n8gJ+Kqp4Plg=
 github.com/pingcap/tidb/parser v0.0.0-20220511160835-98c31070d958/go.mod h1:ElJiub4lRy6UZDb+0JHDkGEdr6aOli+ykhyej7VCLoI=
 github.com/pingcap/tidb/parser v0.0.0-20231010115255-ec2731b8f539 h1:q9m7W3fJRAgmIwRckzxxrqWX/QRuQrXnVJSc5do1New=