Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog-filter: add new event type #655

Merged
merged 15 commits into from
Jul 13, 2022
Merged

binlog-filter: add new event type #655

merged 15 commits into from
Jul 13, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jul 4, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #656
ref pingcap/tiflow#6160

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Increased code complexity

Related changes

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from GMHDBJD and liuzix July 4, 2022 04:27
@ti-chi-bot ti-chi-bot added size/XXL and removed size/L labels Jul 4, 2022
@asddongmen asddongmen force-pushed the add_new_binlog_filter_event_type branch from 3db875a to e5834c5 Compare July 4, 2022 04:44
@ti-chi-bot ti-chi-bot added size/L and removed size/XXL labels Jul 4, 2022
@asddongmen asddongmen changed the title [WIP] binlog-filter: add new event type binlog-filter: add new event type Jul 4, 2022
@asddongmen asddongmen requested a review from lance6716 July 4, 2022 05:27
okJiang
okJiang approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/binlog-filter/filter_test.go Outdated Show resolved Hide resolved
lance6716
lance6716 requested changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need discuss with PM

@asddongmen asddongmen mentioned this pull request Jul 8, 2022
Closed
5 tasks
@ti-chi-bot ti-chi-bot added size/M and removed size/L labels Jul 13, 2022
lance6716
lance6716 reviewed Jul 13, 2022
View reviewed changes
pkg/binlog-filter/filter.go Outdated Show resolved Hide resolved
pkg/binlog-filter/filter.go Show resolved Hide resolved
pkg/binlog-filter/filter.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Jul 13, 2022
lance6716
lance6716 reviewed Jul 13, 2022
View reviewed changes
pkg/binlog-filter/filter.go Outdated Show resolved Hide resolved
pkg/binlog-filter/filter.go Outdated Show resolved Hide resolved
pkg/binlog-filter/filter_test.go Show resolved Hide resolved
pkg/binlog-filter/util.go Show resolved Hide resolved
lance6716
lance6716 reviewed Jul 13, 2022
View reviewed changes
pkg/binlog-filter/filter_test.go
for _, cs := range cases {
event, err := toEventType(cs.eventStr)
c.Assert(cs.event, Equals, event)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when err == nil, should also check cs.err is also nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a741961

@ti-chi-bot ti-chi-bot merged commit 16329cf into pingcap:master Jul 13, 2022
@GMHDBJD GMHDBJD mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
size/L status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new event type for binlog-filter.
5 participants
@asddongmen @ti-chi-bot @CLAassistant @lance6716 @okJiang