util/types: fix parsing datatime 00-00-00 #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00-00-00 should not be adjust year to 2000-00-00
|
LGTM |
XuHuaiyu
reviewed
Jun 23, 2017
| @@ -48,6 +48,8 @@ func (s *testTimeSuite) TestDateTime(c *C) { | |||
| {"20121231113045", "2012-12-31 11:30:45"}, | |||
| {"121231113045", "2012-12-31 11:30:45"}, | |||
| {"2012-02-29", "2012-02-29 00:00:00"}, | |||
| {"00-00-00", "0000-00-00 00:00:00"}, | |||
| {"00-00-00 00:00:00.123", "2000-00-00 00:00:00"}, | |||
There was a problem hiding this comment.
why not 2000-00-00 00:00:00.123? @tiancaiamao
There was a problem hiding this comment.
Because ParseDataTime use DefaultFsp which is 0, fsp part is ignored. @XuHuaiyu
|
LGTM |
zimulala
previously approved these changes
Jun 23, 2017
XuHuaiyu
approved these changes
Jun 23, 2017
tiancaiamao
added a commit
that referenced
this pull request
Jul 13, 2017
00-00-00 should not be adjust year to 2000-00-00
tiancaiamao
added a commit
that referenced
this pull request
Jul 13, 2017
* expression, executor: fix hex(binary) (#3567) * expression, executor: fix unhex(binary) error (#3569) * expression: builtin now() should consider timestamp variable (#3590) * tidb/privilege/privileges: make show databases available with any global privilege (#3666) * privilege/privileges: skip privilege check for information_schema database (#3675) * conn: fix database info leaking problem (#3699) * server: escape database name "use `xxx`" in OpenCtx (#3713) * executor: fix explicitly insert null value into timestamp column (#3646) * util/types: fix parsing datatime 00-00-00 (#3536) * tidb-server: fix incorrect error message when auth failed (#3696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
00-00-00 should not be adjust year to 2000-00-00
It should be:
But we got: