util/types: fix parsing datatime 00-00-00 (#3536)

00-00-00 should not be adjust year to 2000-00-00
pingcap · Jun 23, 2017 · dcf0da9 · dcf0da9
1 parent 4db09e0
commit dcf0da9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/util/types/time.go b/util/types/time.go
@@ -610,7 +610,11 @@ func parseDatetime(str string, fsp int) (Time, error) {
 	// we should adjust it.
 	// TODO: adjust year is very complex, now we only consider the simplest way.
 	if len(seps[0]) == 2 {
-		year = adjustYear(year)
+		if year == 0 && month == 0 && day == 0 && hour == 0 && minute == 0 && second == 0 && fracStr == "" {
+			// Skip a special case "00-00-00".
+		} else {
+			year = adjustYear(year)
+		}
 	}
 
 	microsecond, overflow, err := parseFrac(fracStr, fsp)

diff --git a/util/types/time_test.go b/util/types/time_test.go
@@ -48,6 +48,8 @@ func (s *testTimeSuite) TestDateTime(c *C) {
 		{"20121231113045", "2012-12-31 11:30:45"},
 		{"121231113045", "2012-12-31 11:30:45"},
 		{"2012-02-29", "2012-02-29 00:00:00"},
+		{"00-00-00", "0000-00-00 00:00:00"},
+		{"00-00-00 00:00:00.123", "2000-00-00 00:00:00"},
 	}
 
 	for _, test := range table {