Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression, executor: fix unhex(binary) error #3569

Merged
merged 3 commits into from
Jun 29, 2017
Merged

expression, executor: fix unhex(binary) error #3569

merged 3 commits into from
Jun 29, 2017

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jun 29, 2017

Keep the same behavior with mysql when column type is binary.

create table t (a binary(8));
insert into t value('test');
select unhex(s) from t1;
+----------+
| unhex(s) |
+----------+
| NULL     |
+----------+

@shenli @XuHuaiyu PTAL

@jackysp jackysp requested review from shenli and XuHuaiyu June 29, 2017 08:18
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@XuHuaiyu
Copy link
Contributor

LGTM

@jackysp jackysp requested a review from hanfei1991 June 29, 2017 08:30
@shenli
Copy link
Member

shenli commented Jun 29, 2017

LGTM
Please resolve the conflicts.

shenli
shenli previously approved these changes Jun 29, 2017
View reviewed changes
@jackysp
Copy link
Member Author

jackysp commented Jun 29, 2017

Conflicts resolved PTAL @shenli @XuHuaiyu

@XuHuaiyu XuHuaiyu merged commit 284ac94 into master Jun 29, 2017
@XuHuaiyu XuHuaiyu deleted the yusp/hex_support_bytes branch June 29, 2017 10:07
tiancaiamao pushed a commit that referenced this pull request Jul 13, 2017
@jackysp @tiancaiamao
expression, executor: fix unhex(binary) error (#3569)
b7d7779
tiancaiamao added a commit that referenced this pull request Jul 13, 2017
@tiancaiamao
*: cherry pick many bug fix since rc3 (#3713) (#3743)
9a80487 
* expression, executor: fix hex(binary) (#3567)

* expression, executor: fix unhex(binary) error (#3569)

* expression: builtin now() should consider timestamp variable (#3590)

* tidb/privilege/privileges: make show databases available with any global privilege (#3666)

* privilege/privileges: skip privilege check for information_schema database (#3675)

* conn: fix database info leaking problem (#3699)

* server: escape database name "use `xxx`" in OpenCtx (#3713)

* executor: fix explicitly insert null value into timestamp column (#3646)

* util/types: fix parsing datatime 00-00-00 (#3536)

* tidb-server: fix incorrect error message when auth failed (#3696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@shenli shenli shenli left review comments

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @CLAassistant @XuHuaiyu @shenli