tidb/privilege/privileges: make show databases available with any global privilege #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Add a test about |
tiancaiamao
force-pushed
the
tiancaiamao/show-databases
branch
from
c6023bb to
01779bd
Compare
|
LGTM |
zimulala
added
status/LGT2
zimulala
approved these changes
Jul 8, 2017
tiancaiamao
added a commit
that referenced
this pull request
Jul 13, 2017
…bal privilege (#3666) * tidb/privilege/privileges: make show databases available with any global privilege
tiancaiamao
added a commit
that referenced
this pull request
Jul 13, 2017
* expression, executor: fix hex(binary) (#3567) * expression, executor: fix unhex(binary) error (#3569) * expression: builtin now() should consider timestamp variable (#3590) * tidb/privilege/privileges: make show databases available with any global privilege (#3666) * privilege/privileges: skip privilege check for information_schema database (#3675) * conn: fix database info leaking problem (#3699) * server: escape database name "use `xxx`" in OpenCtx (#3713) * executor: fix explicitly insert null value into timestamp column (#3646) * util/types: fix parsing datatime 00-00-00 (#3536) * tidb-server: fix incorrect error message when auth failed (#3696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #3656
In the old code,
show databasesreturns non-empty result when the user has ShowDBPriv,now it's change to any global privilege.
Ref: https://dev.mysql.com/doc/refman/5.7/en/show-databases.html
The actual behavior is not the same as it says:
@zimulala @hanfei1991 @shenli @XuHuaiyu