Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conn: fix database info leaking problem #3699

Merged
merged 3 commits into from
Jul 11, 2017
Merged

conn: fix database info leaking problem #3699

merged 3 commits into from
Jul 11, 2017

Conversation

choleraehyq
Copy link
Contributor

@choleraehyq choleraehyq commented Jul 11, 2017

fix #3682.

@tiancaiamao @zimulala PTAL.

Signed-off-by: Cholerae Hu [email protected]

@breezewish
Copy link
Member

LGTM

@choleraehyq choleraehyq force-pushed the hyq/fix#3682 branch 5 times, most recently from 8a410f6 to b3c4ab6 Compare July 11, 2017 03:29
@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2017
@choleraehyq choleraehyq force-pushed the hyq/fix#3682 branch 5 times, most recently from 7a8917e to 6c7bbcc Compare July 11, 2017 06:58
Cholerae Hu added 3 commits July 11, 2017 16:15
Signed-off-by: Cholerae Hu <[email protected]>
Signed-off-by: Cholerae Hu <[email protected]>
Signed-off-by: Cholerae Hu <[email protected]>
@choleraehyq
Copy link
Contributor Author

@coocood @lamxTyler PTAL

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit c8feff8 into master Jul 11, 2017
@hanfei1991 hanfei1991 deleted the hyq/fix#3682 branch July 11, 2017 09:39
tiancaiamao added a commit that referenced this pull request Jul 13, 2017
* expression, executor: fix hex(binary) (#3567)

* expression, executor: fix unhex(binary) error (#3569)

* expression: builtin now() should consider timestamp variable (#3590)

* tidb/privilege/privileges: make show databases available with any global privilege (#3666)

* privilege/privileges: skip privilege check for information_schema database (#3675)

* conn: fix database info leaking problem (#3699)

* server: escape database name "use `xxx`" in OpenCtx (#3713)

* executor: fix explicitly insert null value into timestamp column (#3646)

* util/types: fix parsing datatime 00-00-00 (#3536)

* tidb-server: fix incorrect error message when auth failed (#3696)
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB can leak info about the existence of a specific database without any valid credentials
5 participants