Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.6 #781

Closed
samreid opened this issue Feb 8, 2017 · 17 comments
Closed

Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.6 #781

samreid opened this issue Feb 8, 2017 · 17 comments
Assignees
Labels

Comments

@samreid
Copy link
Member

samreid commented Feb 8, 2017

In phetsims/circuit-construction-kit-black-box-study#40 I prepared a new version of Circuit Construction Kit: Black Box Study which will be used by our collaborators at Stanford in an upcoming study.

The first 1.1 RC is published here
UPDATE: see new version here #781 (comment)
UPDATE: see newer version here: #781 (comment)
UPDATE: rc4 is available here: #781 (comment)
UPDATE: we are up to 6

The previous version we had been supporting for them in the branch was getting so stale it was no longer able to semi-automatically maintain it with corresponding changes in master. Hence we are creating a new version based on master to update the SHAs. There have been numerous significant refactoring steps, so it will need to be tested rigorously. If it passes testing, these SHAs will become the new maintenance SHAs and will be able to be kept in sync with master much easier.

I do not think this version requires exhaustive multi-platform testing. Many of the refactoring steps are in the simulation logic (not, say, in WebGL or other parts that may behave differently on different platforms). On the other hand, if this version does well in testing, it may supercede #765 (in which case we would want pretty broad platform testing, including iPad).

According to phetsims/circuit-construction-kit-black-box-study#25 another usage of this simulation is coming up soon, which will use the data stream and visual record/playback, so at a minimum those PhET-iO features should be tested. The wrapper index is here: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-black-box-study/1.1.0-phetiorc.1/wrappers/index/ .
(UPDATE: see new version here #781 (comment) ):

@arouinfar should be on this testing team since she is most familiar with the requested features and desired behavior for this application. Support from the rest of the QA team will also be valuable. @arouinfar can you please review this issue and add anything I've missed, or any other recommendations? Also assigning to @ariel-phet for prioritization, scheduling and delegation for the QA team side.

Also, @arouinfar I recall the last time we shared this with Stanford, there were numerous links with different query parameters. Do you know if they still need all those variants? If so, please post the links here (for the new 1.1.0-phetiorc.1 version) and we can test them too.

@samreid samreid changed the title Test Circuit Construction Kit: Black Box Study Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.1 Feb 8, 2017
@ariel-phet
Copy link

ariel-phet commented Feb 8, 2017

@phet-steele next in line after 780

EDIT: SR Unmarked issue 780 so it doesn't appear with the issues that must be fixed.

@arouinfar
Copy link

arouinfar commented Feb 9, 2017

There are four query parameters to test (including in combination with one another).

&showPlayPauseButton

  • A play/pause button appears in the lower left corner of the sim.
  • In "pause" mode the sim background is gray.
  • In "pause" mode voltmeter and current meter will have a blank display.
  • Electrons will not flow until "play" is pressed.
  • In "play" mode, most actions will trigger "pause" mode. The exception is translation of a circuit component within the play area.

&showRevealButton=false
This will remove the Reveal button from the Black Box screen

&showElectronsCheckBox=false
Removes the "Show Electrons" checkbox from both screens.

&showControlPanel=false
Removes the panel containing the "Labels" and "Show Electrons" checkboxes.

The last two query parameters both affect the control panel, so there's no need to use them both together.

@samreid
Copy link
Member Author

samreid commented Feb 9, 2017

These query parameters came in handy during debugging and I realized they may also come in handy during testing:

&vertexDisplay=index&dev shows the vertex indices and makes the black box semi-transparent:
image

&vertexDisplay=voltage shows the voltage for each vertex (no ground).
image

@samreid
Copy link
Member Author

samreid commented Feb 9, 2017

I have fixed 5/6 issues noted above. The sixth is phetsims/circuit-construction-kit-common#251 about the layering of electrons. The layering of electrons and circuit elements has proved tricky, there are many open issues about layering and this will need a significant amount of work. Hence we may leave that one out of RC.2.

samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Feb 9, 2017
@samreid
Copy link
Member Author

samreid commented Feb 9, 2017

I do not believe that testing on rc.1 has completed. Still, since I have addressed 5 of the discovered issues, I decided to publish rc.2. I will leave it up to @phet-steele and @arouinfar whether they want to finish testing rc.1 or switch over to rc.2 now.

http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-black-box-study/1.1.0-phetiorc.2/circuit-construction-kit-black-box-study_en-phetio.html?phetioStandalone

http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-black-box-study/1.1.0-phetiorc.2/wrappers/index/

@samreid samreid changed the title Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.1 Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.2 Feb 9, 2017
@arouinfar
Copy link

I will switch my testing over to rc.2. Thanks @samreid.

@phet-steele
Copy link

I will switch my testing over to rc.2. Thanks @samreid.

Ditto.

@arouinfar
Copy link

@samreid I've finished testing rc.2.

@samreid
Copy link
Member Author

samreid commented Feb 15, 2017

All above issues have been addressed. I'll use master for sun to pick up the slider fix. Otherwise I'll use same SHAs as in RC.2 to minimize testing overhead.

@samreid
Copy link
Member Author

samreid commented Feb 15, 2017

Sun also picked up some changes with respect to dispose(), we should make sure disposing sun components is still OK in RC.3

samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Feb 15, 2017
@samreid samreid assigned samreid and phet-steele and unassigned phet-steele Feb 15, 2017
@samreid
Copy link
Member Author

samreid commented Feb 15, 2017

I noted this issue in RC.3: phetsims/circuit-construction-kit-black-box-study#36 (comment)

@phet-steele and @arouinfar can you please test out RC3 (links above) and see what else remains to be done before sharing with Shima?

@ariel-phet
Copy link

@phet-steele moving to top priority for the moment until complete

samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Feb 17, 2017
@samreid
Copy link
Member Author

samreid commented Feb 17, 2017

I published rc.4 here:
http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-black-box-study/1.1.0-phetiorc.4/wrappers/index/

It addresses 4 of the above open issues. For the unaddressed open issues, I'm hoping we can "punt" on them for our February deadline (say, if they are rare or low enough severity).

@samreid
Copy link
Member Author

samreid commented Feb 17, 2017

@samreid samreid changed the title Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.3 Test Circuit Construction Kit: Black Box Study 1.1.0-phetiorc.6 Feb 17, 2017
@phet-steele
Copy link

For all intents and purposes, this testing is done. The sim has a production version and will soon be delivered. Lowering priority and passing back to @samreid.

@phet-steele phet-steele removed their assignment Feb 17, 2017
@samreid
Copy link
Member Author

samreid commented Feb 22, 2017

Thanks @phet-steele and @arouinfar for all your discoveries during testing, closing.

@samreid samreid closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants