-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider resizes when thumbs at min/max #253
Comments
It seems the best way to address the root cause of this problem would be to add struts or bounds to the slider itself that will account for the half width of the slider. |
We will pursue a solution to this problem in phetsims/sun#282 |
Note: when this is fixed in common code, we will need new SHAs or a common code branch for RC.3. UPDATE: Or just one new SHA. |
Fixed in the sun issue/pending testing/requires new SHA or cherry-pick branch. |
Looks good in rc.3 @samreid. |
@phet-steele can this be closed? |
Indeed it can! Left it open in case you would use it as a reminder for the sun issue. |
I got the new sun sha, so we are good to go. Thanks! |
It looks like the thumb on each slider will reposition the tweakers if the thumb has extended further than the right or left of the track. The reposition/resize only happens after disabling then re-enabling the slider. I used a wire to align to the left edge of a tweaker so it was more obvious when it moved.
Seems eerily familiar to phetsims/rutherford-scattering/issues/97.
Seen on macOS 10.12.3 Chrome. For phetsims/tasks#781.
The text was updated successfully, but these errors were encountered: