Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider resizes when thumbs at min/max #253

Closed
phet-steele opened this issue Feb 9, 2017 · 8 comments
Closed

Slider resizes when thumbs at min/max #253

phet-steele opened this issue Feb 9, 2017 · 8 comments
Assignees
Labels

Comments

@phet-steele
Copy link
Contributor

It looks like the thumb on each slider will reposition the tweakers if the thumb has extended further than the right or left of the track. The reposition/resize only happens after disabling then re-enabling the slider. I used a wire to align to the left edge of a tweaker so it was more obvious when it moved.

  1. Click on a component to enable the slider.
  2. Move the thumb all the way left or right.
  3. Click away from the slider to hide it.
  4. Click on the same component in step 1. The tweakers will have moved outward

cckbbio05

Seems eerily familiar to phetsims/rutherford-scattering/issues/97.

Seen on macOS 10.12.3 Chrome. For phetsims/tasks#781.

@samreid
Copy link
Member

samreid commented Feb 10, 2017

It seems the best way to address the root cause of this problem would be to add struts or bounds to the slider itself that will account for the half width of the slider.

@samreid
Copy link
Member

samreid commented Feb 10, 2017

We will pursue a solution to this problem in phetsims/sun#282

@samreid
Copy link
Member

samreid commented Feb 10, 2017

Note: when this is fixed in common code, we will need new SHAs or a common code branch for RC.3.

UPDATE: Or just one new SHA.

@samreid
Copy link
Member

samreid commented Feb 15, 2017

Fixed in the sun issue/pending testing/requires new SHA or cherry-pick branch.

@phet-steele
Copy link
Contributor Author

Looks good in rc.3 @samreid.

@samreid
Copy link
Member

samreid commented Feb 15, 2017

@phet-steele can this be closed?

@phet-steele
Copy link
Contributor Author

can this be closed?

Indeed it can! Left it open in case you would use it as a reminder for the sun issue.

@samreid
Copy link
Member

samreid commented Feb 15, 2017

I got the new sun sha, so we are good to go. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants