Solder should be rendered properly on startup

[samreid]

From #31

@kathy-phet said:

only comment I have is it would be incrementally improved if the solder joints were layered on top ... right now they seem to be below the special stubs. But certainly could leave as it is.

and

noticed solder joints do show up nicely on joints after pressing reset all ... if they could start with that look it seems like it would be better.

@arouinfar said:

I haven't found any issues with 1.0.8-dev.3, aside from the solder joint issue that @kathy-phet described.

This should be implemented for the 1.0.8 branch and for master.

[samreid]

In the preceding commit, I added a workaround for showing the solder in the correct order. It is published here:
http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-black-box-study/1.0.8-dev.4/circuit-construction-kit-black-box-study_en.html

I spent nearly an hour investigating the "right way" to do this, but given the current implementation it would have been very convoluted, so I resorted to this 2-line workaround which seems to behave nicely.

The workaround is to reset the model and view on startup, which may have (but hopefully does not) have unintended consequences.

@arouinfar and @kathy-phet would you like to review this version? Should @phet-steele dev test it? After this, should we move forward with an RC and more elaborate testing? I'll still need to publish the PhET brand of this, the current dev version is the PhET brand.

[arouinfar]

@samreid the workaround seems to be working fine. I can do a bit more testing on 1.0.8-dev.4, but I think we'll want to wait for the fire artwork (phetsims/circuit-construction-kit-common#72) and hiding the reveal button (#37) before doing more elaborate testing or getting @phet-steele on board.

[arouinfar]

Tagging for #32.

[samreid]

@arouinfar can this issue be closed?

[arouinfar]

I'll go ahead and close this issue, and open new issues if I find anything else in 1.0.8-dev.4.

[arouinfar]

In 1.0.8-dev.9, I noticed that the solder joint can become transparent if you

• Go to Black Box on startup. Solder joint looks fine.
• Switch to Test, and then back to Explore.
• Solder joint is now transparent and remains transparent, even when components are attached.
  

I retested 1.0.8-dev.4, and the issue is also present there.

[samreid]

I moved the preceding comment to a new issue, closing.

[samreid]

Reopening for phetsims/tasks#781 but as pointed out in #46 we will need a better solution.

[samreid]

Proposed fix is above. Fairly significant change, may have disturbed some other aspect of layering. I may need to redo the entire layering subsystem before this is published on our website. But maybe this will be good enough for RC.3.

[samreid]

In rc.3 it looks like this on startup or reset:

When attaching a wire to the black box vertex, I see this:

Unexpected and not ideal, but it doesn't seem like a showstopper for sharing.

[phet-steele]

@samreid, in rc.3 anything attached to the BB will be layered above the BB at first, but then be layered under it when switching to and back from another challenge.

Before switch:

After switch:

[phet-steele]

Going to move the above comment to a new issue.

[phet-steele]

#36 (comment) also occurs when toggling play/pause (with nothing attached).

[samreid]

@arouinfar is the behavior in http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-black-box-study/1.1.0-phetiorc.4/wrappers/index/ acceptable for our February deadline?

[kathy-phet]

Sam - The layering issue shown in r3 where the circuit elements end up behind the black box seems problematic for an actual classroom use.

[arouinfar]

@kathy-phet that particular layering issue is not present in rc.4. See #48.

[kathy-phet]

Oh - I see I thought Sam was talking about rc.3. I see now its rc.4.

[arouinfar]

@samreid I haven't found any issues with the solder rendering on startup, or the re-layering described in #36 (comment) in rc.4.