Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State is no longer saved when switching between BB challenges #46

Closed
phet-steele opened this issue Feb 9, 2017 · 5 comments
Closed
Assignees
Labels

Comments

@phet-steele
Copy link
Contributor

It is my understanding that state is supposed to be saved.

I have a bunch of objects out in the warm-up, then switch away and back to it and the objects are reset:

cckbbio06

Seen on macOS 10.12.3 Chrome. For phetsims/tasks#781.

@samreid
Copy link
Member

samreid commented Feb 10, 2017

The workaround for #36 introduced this problem.

@samreid
Copy link
Member

samreid commented Feb 10, 2017

The transparency effect is because the wire is transparent and the solder is behind the wire.

@samreid
Copy link
Member

samreid commented Feb 10, 2017

Fixed in the above commit, leaving open until verified in RC.3.

@arouinfar
Copy link

When this issue is verified, we should also make sure that the Reset All button only effects the current black box. Given that the states weren't properly saved in rc.2, it was impossible to test the Reset All behavior.

@phet-steele
Copy link
Contributor Author

Looks good in rc.3.

we should also make sure that the Reset All button only effects the current black box.

It does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants