Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Parameter to hide "Show Electrons" checkbox no longer works #45

Closed
arouinfar opened this issue Feb 8, 2017 · 4 comments
Closed
Assignees
Labels

Comments

@arouinfar
Copy link

For phetsims/tasks#781.

The query parameter previously used to hide the "Show Electrons" checkbox no longer works. My suspicion is that the addition of the "Labels" checkbox to the panel may be to blame.

Here's the query parameter in question:

?phet-io.expressions=%5B%5B%22circuitConstructionKitBlackBoxStudy.exploreScreen.view.displayOptionsPanel%22,%22setVisible%22,%5Bfalse%5D%5D,%5B%22circuitConstructionKitBlackBoxStudy.blackBoxScreen.view.warmupSceneView.displayOptionsPanel%22,%22setVisible%22,%5Bfalse%5D%5D%5D

@samreid
Copy link
Member

samreid commented Feb 9, 2017

In the above commit, I added 2 query parameters.

showElectronsCheckBox=false will hide the electrons checkbox, while leaving the "labels" checkbox

showControlPanel=false will hide the entire panel (with both labels and electrons, and eventually more controls to come in the dc version).

Leaving open for verification when rc.2 is ready.

@phet-steele
Copy link
Contributor

@samreid they work for me, nice work! I'll assign to @arouinfar to check out so she is aware.

@phet-steele phet-steele assigned arouinfar and unassigned samreid Feb 9, 2017
@arouinfar
Copy link
Author

@samreid looks great, thanks! These new query parameters are much easier to remember too. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants