Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish PhET-iO dev versions for the client #296

Closed
jbphet opened this issue Jun 4, 2020 · 14 comments
Closed

publish PhET-iO dev versions for the client #296

jbphet opened this issue Jun 4, 2020 · 14 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 4, 2020

@kathy-phet would like to deliver PhET-iO dev versions of both states-of-matter and states-of-matter-basics to the client for review.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 4, 2020

During the 6/4/2020 phet-io meeting we reviewed a list of phet-io issues that could potentially block the sharing of dev version. @zepumph said he'd add them to this issue.

@zepumph
Copy link
Member

zepumph commented Jun 4, 2020

Yes thanks. The outline for this issue is as follows (largely copied from phetsims/ph-scale#164 (comment)):

the process is:

  1. Determine what sim specific issues need to be done before publishing the dev version.
  2. sign off on open issues labeled "status:blocks-publication". We did this as a group today.
  1. @jbphet : publish dev versions, add links to this issue
  2. @arouinfar : review and sign off
  3. @kathy-phet: delivery to the client

also see https://github.com/phetsims/phet-io/issues/1680 for central documentation that will be created for this process.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 8, 2020

@jbphet
Copy link
Contributor Author

jbphet commented Jun 17, 2020

Update

As of this writing, there is one blocking issue listed above, and it's https://github.com/phetsims/studio/issues/30. This is in turn waiting on the completion of QA testing in phetsims/qa#508. I just checked in with @zepumph via Slack, and he said that once that testing is complete, assuming no major problems are found, we should be clear to move forward with a dev release to the customer.

I also checked in with @arouinfar as to whether she would want to review the studio tree once the studio code had been updated, given that there has been a fair amount of change both the SOM and the studio code. She said that yes, she would.

@zepumph
Copy link
Member

zepumph commented Jun 18, 2020

That all sounds great. I also want to add that when you are getting ready for another dev version, @zepumph and @arouinfar should look through the issues that came out of phetsims/qa#508 to see if any should block this dev version.

@arouinfar
Copy link
Contributor

@jbphet I spent quite a bit of time reviewing master in studio, and aside from the issues mentioned in https://github.com/phetsims/studio/issues/28#issuecomment-648254742 and https://github.com/phetsims/studio/issues/28#issuecomment-648286832 the tree looked undisturbed to me. I don't think this should block dev delivery to the client, however.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 24, 2020

Two more issues came up during testing that I think should be resolved before release:

@jbphet
Copy link
Contributor Author

jbphet commented Jun 24, 2020

Though not strictly blocking, I decided to address this one too:

@zepumph
Copy link
Member

zepumph commented Jun 25, 2020

@chrisklus and @arouinfar will work on getting the client guide for SOM built with the sim, and then this dev version is ready to publish.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 25, 2020

@chrisklus and @arouinfar have confirmed that they have made the necessary commits for the client guide. I just did a local build and reviewed the client guide with @arouinfar and didn't see any dev-version-blocking problems.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 25, 2020

I've built and sanity tested dev versions. Here are the links (password required):

I'll leave this issue assigned to myself until I hear that these have been delivered and will update then.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 25, 2020

I wanted to note that in today's status meeting we decided that enough testing had been done on this and there was not a need to set up QA tasks to test these dev versions.

@kathy-phet
Copy link

Delivered!

@jbphet
Copy link
Contributor Author

jbphet commented Jun 26, 2020

This is done. I will follow up on some other items that still need to be done in order to call the phet-io instrumentation effort complete, but that will be tracked in #245, so I'll close this one.

@jbphet jbphet closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants