Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish PhET-iO dev version for the client #345

Closed
7 of 8 tasks
zepumph opened this issue Jun 4, 2020 · 14 comments
Closed
7 of 8 tasks

publish PhET-iO dev version for the client #345

zepumph opened this issue Jun 4, 2020 · 14 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jun 4, 2020

We are not quite ready for this issue I think, but I thought I would take new documentation for a test drive in this repo. Here is the issue:

@kathy-phet would like to deliver a PhET-iO dev version of gravity and orbits to the client for review.

    • Determine what sim specific issues need to be done before publishing the dev version.
  1. Look at open issues labeled "status:blocks-publication". Determine which need to be done for this release, and which can wait until RC.
    • Here is the list of issues that need to be done for this dev release:
      • . . .
    • Here is the list of issues that are currently marked as "status:blocks-publication" but don't need to be done for this dev version:
      • . . .
    • Dev test the simulation. Create a QA dev test template issue and include the PhET-iO section.
    • Address issues that come out of testing. Triage with your designer, as it is possible that not all need to be addressed for the dev version.
    • @samreid: publish dev versions, add links to this issue

Note that for (2), there is a good chance that this will be a similar list as in (2) in phetsims/states-of-matter#296 (comment)

@samreid
Copy link
Member

samreid commented Jul 20, 2020

@arouinfar and I triaged issues, and the only remaining issues are scheduled for RC and not necessary for dev. I reviewed the general blocks-publication issues and they don't seem like they would disturb a dev version.

I published this dev version.

Deployed: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.11/phet/gravity-and-orbits_en_phet.html
Deployed: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.11/phet-io/

@arouinfar can you please spot check these versions? If they seem OK to you, I'll open a QA dev test issue. If that checks out, we can deliver this dev version to the client.

@arouinfar
Copy link
Contributor

@samreid I spot tested the dev version, and it seems to be in working order. However, this version was published before I finished the client guides. Would it be relatively straightforward publish a new dev version for QA testing so the guides get picked up in the build?

@arouinfar arouinfar assigned samreid and unassigned arouinfar Jul 21, 2020
@samreid
Copy link
Member

samreid commented Jul 21, 2020

Here is a new version that includes the client requests and guide:

https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.12/phet/gravity-and-orbits_en_phet.html
https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.12/phet-io/

I took a quick glance at them and did not see any obvious problems. At this point, I'd like to create a QA issue to get it scheduled in the pipeline. But I'm also leaving assigned to @arouinfar for a spot check for dev.12 -- please let me know right away if something is out of order and I'll invalidate or update the QA issue.

@samreid
Copy link
Member

samreid commented Jul 21, 2020

I created the QA issue, linked above.

@arouinfar
Copy link
Contributor

@samreid I reviewed this last week (but forgot to comment/close), and everything was looking good.

@samreid
Copy link
Member

samreid commented Jul 30, 2020

I recommend to leave this open until the dev version has been delivered to the client.

@samreid samreid reopened this Jul 30, 2020
@arouinfar arouinfar removed their assignment Aug 4, 2020
@samreid
Copy link
Member

samreid commented Nov 2, 2020

The only common code issue pertinent to this deploy is phetsims/chipper#787. @jessegreenberg and I discussed and @jessegreenberg recommended:

I would probably revert for for your publication since the issue did not manifest itself in GAO, and this change may have an unintended consequence. But leave in master with blocks-publication until JO can review behavior.

So I'll create RC.1 from master, then make a maintenance release to revert the chipper changes.

samreid added a commit to phetsims/chipper that referenced this issue Nov 2, 2020
samreid added a commit to phetsims/chipper that referenced this issue Nov 2, 2020
samreid added a commit to phetsims/chipper that referenced this issue Nov 2, 2020
… </script> tags in html comment blocks. See #787."

This reverts commit cb2e957, see phetsims/gravity-and-orbits#345
@samreid
Copy link
Member

samreid commented Nov 2, 2020

@samreid samreid added this to the 1.3 "rc-lite" milestone Nov 11, 2020
@samreid
Copy link
Member

samreid commented Nov 14, 2020

All blocks-publication issues are cleared. I ran a grunt rc command for 1.3, but it doesn't look like the build is completing (at least after 5 minutes).

UPDATE: I wrote on slack:

I ran a grunt rc command for gravity-and-orbits about 5 minutes ago, and I haven’t seen any build outputs yet. I think it normally would have completed by now. Is anyone aware of build-server outages? What is the best way to debug this kind of problem?

I followed the instructions in https://github.com/phetsims/perennial/blob/master/js/build-server/README.md for outputting the build server logs, but they said permission denied, even when I logged in the admin account.

@samreid
Copy link
Member

samreid commented Dec 4, 2020

I asked on slack:

This is my first experience delivering an RC-Lite version to a client. Do we give them a link to an RC, or do we publish a production version? If we publish a production version, how do we prevent it from being published on the main site?

@samreid
Copy link
Member

samreid commented Dec 4, 2020

On slack @zepumph said:

I thought that RC LIte was delivered through phet-dev. Let me check the docs.
We still haven't updated the docs from "initial dev version" to "rc lite", which makes me more confident that we just deliver from phet-dev: https://github.com/phetsims/phet-io/blob/master/doc/phet-io-instrumentation-technical-guide.md#initial-dev-release-to-client

I asked:

Does “deliver from phet-dev” mean I give the link to an RC version?
Or I somehow publish a production version on phet-dev?

@zepumph replied:

just an RC version.

@samreid
Copy link
Member

samreid commented Dec 4, 2020

All issues discovered during QA lite were confirmed in the RC.3 or determined to be unnecessary for this release. So https://phet-dev.colorado.edu/html/gravity-and-orbits/1.3.0-rc.3/phet-io/ is ready to deliver to the client.

@samreid
Copy link
Member

samreid commented Dec 4, 2020

I captured some slack discussion in a private issue.

@samreid
Copy link
Member

samreid commented Dec 11, 2020

I believe @kathy-phet delivered a dev version (the RC) to our client. Closing.

@samreid samreid closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants