-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish PhET-iO dev version for the client #345
Comments
@arouinfar and I triaged issues, and the only remaining issues are scheduled for RC and not necessary for dev. I reviewed the general blocks-publication issues and they don't seem like they would disturb a dev version. I published this dev version. Deployed: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.11/phet/gravity-and-orbits_en_phet.html @arouinfar can you please spot check these versions? If they seem OK to you, I'll open a QA dev test issue. If that checks out, we can deliver this dev version to the client. |
@samreid I spot tested the dev version, and it seems to be in working order. However, this version was published before I finished the client guides. Would it be relatively straightforward publish a new dev version for QA testing so the guides get picked up in the build? |
Here is a new version that includes the client requests and guide: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.12/phet/gravity-and-orbits_en_phet.html I took a quick glance at them and did not see any obvious problems. At this point, I'd like to create a QA issue to get it scheduled in the pipeline. But I'm also leaving assigned to @arouinfar for a spot check for dev.12 -- please let me know right away if something is out of order and I'll invalidate or update the QA issue. |
I created the QA issue, linked above. |
@samreid I reviewed this last week (but forgot to comment/close), and everything was looking good. |
I recommend to leave this open until the dev version has been delivered to the client. |
The only common code issue pertinent to this deploy is phetsims/chipper#787. @jessegreenberg and I discussed and @jessegreenberg recommended:
So I'll create RC.1 from master, then make a maintenance release to revert the chipper changes. |
This reverts commit 2b2190d, see phetsims/gravity-and-orbits#345
This reverts commit 65b7959, see phetsims/gravity-and-orbits#345
… </script> tags in html comment blocks. See #787." This reverts commit cb2e957, see phetsims/gravity-and-orbits#345
I published these versions and will update the "RC-lite" issue: Deployed: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-rc.2/phet/gravity-and-orbits_en_phet.html |
All blocks-publication issues are cleared. I ran a UPDATE: I wrote on slack:
|
I asked on slack:
|
On slack @zepumph said:
I asked:
@zepumph replied:
|
All issues discovered during QA lite were confirmed in the RC.3 or determined to be unnecessary for this release. So https://phet-dev.colorado.edu/html/gravity-and-orbits/1.3.0-rc.3/phet-io/ is ready to deliver to the client. |
I captured some slack discussion in a private issue. |
I believe @kathy-phet delivered a dev version (the RC) to our client. Closing. |
We are not quite ready for this issue I think, but I thought I would take new documentation for a test drive in this repo. Here is the issue:
@kathy-phet would like to deliver a PhET-iO dev version of gravity and orbits to the client for review.
Note that for (2), there is a good chance that this will be a similar list as in (2) in phetsims/states-of-matter#296 (comment)
The text was updated successfully, but these errors were encountered: