Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atoms panel title is not instrumented #301

Closed
arouinfar opened this issue Jun 24, 2020 · 2 comments
Closed

Atoms panel title is not instrumented #301

arouinfar opened this issue Jun 24, 2020 · 2 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

Noticed during review for #296 and https://github.com/phetsims/phet-io-client-guides/issues/5

The Atoms & Molecules panel title is editable on the first two screens.

  • statesOfMatter.statesScreen.view.moleculesControlPanel.title.textProperty
  • statesOfMatter.phaseChangesScreen.view.moleculesControlPanel.title.textProperty

The equivalent Atoms panel on the Interaction screen does not have its title instrumented.
image

@jbphet this seems like an oversight to me. Can you instrument the panel title? The client does not plan to use the Interaction screen, so I'll leave it up to you to decide whether or not to include this change in the upcoming dev release.

@jbphet
Copy link
Contributor

jbphet commented Jun 24, 2020

'Twas indeed an oversight. I instrumented it and added dynamic layout. @arouinfar - please check on master and close if it looks good.

@arouinfar
Copy link
Contributor Author

Thanks @jbphet! Looks good in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants