Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction scene pause button doesn't reset #300

Closed
KatieWoe opened this issue Jun 23, 2020 · 4 comments
Closed

Interaction scene pause button doesn't reset #300

KatieWoe opened this issue Jun 23, 2020 · 4 comments
Labels
type:bug

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#508, but reproduced on phetsims/qa#501. Not in published. Win 10 Edge.
When you pause the sim in the interaction screen, hitting the reset all button does not un-pause it. This occurs regardless of any other changes (though the other changes do seem to reset. Other screens do not seem impacted.
pausedoesntreset
@zepumph
Copy link
Member

zepumph commented Jun 24, 2020

I think this one is sim-specific, over to you @jbphet.

@zepumph zepumph assigned jbphet and unassigned jbphet and zepumph Jun 24, 2020
jbphet added a commit that referenced this issue Jun 24, 2020
@jbphet
reset isPlayingProperty, see #300
e5c5746
@jbphet
Copy link
Contributor

jbphet commented Jun 24, 2020

Should be fixed now. @KatieWoe, please verify on master and leave open for next round of pre-release testing.

@jbphet jbphet assigned KatieWoe and unassigned jbphet Jun 24, 2020
@jbphet jbphet mentioned this issue Jun 24, 2020
Closed
@KatieWoe
Copy link
Contributor Author

Looks good on master

@KatieWoe KatieWoe removed their assignment Jun 25, 2020
@jbphet jbphet mentioned this issue Jul 31, 2020
Closed
13 tasks
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Aug 4, 2020

Looks good in phetsims/qa#525. Will reopen if something shows up.

@KatieWoe KatieWoe closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbphet @zepumph @KatieWoe