Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: States of Matter 1.2.0-rc.1 #525

Closed
10 of 13 tasks
jbphet opened this issue Jul 31, 2020 · 12 comments
Closed
10 of 13 tasks

RC test: States of Matter 1.2.0-rc.1 #525

jbphet opened this issue Jul 31, 2020 · 12 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 31, 2020

@KatieWoe , @ariel-phet, @arouinfar, and @kathy-phet - states-of-matter/1.2.0-rc.1 is ready for RC testing. This includes both phet and phet-io brand and intended to be shared with a client in mid-August. Document issues in https://github.com/phetsims/states-of-matter/issues and link to this issue.

Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book
    for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Test the Game Up harness on at least one platform.
  • Check this LoL
    spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version
  • Try to include version numbers for browsers
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if
    there is a problem.

Focus and Special Instructions

Since the phet-io version is being shared with a client who intends to integrate it into a learning environment, the phet-io version should be thoroughly tested. Also, lots of under-the-hood changes have occurred, so the phet version should get a fair amount of scrutiny too.

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)


PhET-iO RC Test

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.
  • For an update or maintenance release please check the backwards compatibility of the playback wrapper.
    Here's the link to the previous wrapper.
  • Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:
    /wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER
    
    Further instructions in QA Book
  • Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other random platform.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet
Copy link
Contributor

Given the aim of getting this sim to the client by mid-August this must be top priority in testing

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 4, 2020

Memory test for normal sim:
normalmemtest
Memory test for phet-io sim:
phetiomemtest

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 7, 2020

I wanted to note that, while the memory tests are fine, I did notice that a few devices were running a bit harder/fans were running more than I usually see.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 10, 2020

@KatieWoe said:

I wanted to note that, while the memory tests are fine, I did notice that a few devices were running a bit harder/fans were running more than I usually see.

Is there a way that this can be quantified? I'd suggest running a test where the published version is run in an incognito Chrome window and the CPU usage measured using Windows task manager, then the same test is performed with the RC version. If the differences are measurable and significant, we can then decide if this warrants additional investigation.

@KatieWoe
Copy link
Contributor

Metacog recording test done for Win 10 Chrome and IPadOS 13 Safari.
Safari on iPad seemed to have jumps/small lags when making the recording. I'll leave it to @jbphet and @zepumph to decide if this needs to be addressed.

@jbphet
Copy link
Contributor Author

jbphet commented Aug 12, 2020

@KatieWoe said:

Safari on iPad seemed to have jumps/small lags when making the [Metacog] recording. I'll leave it to @jbphet and @zepumph to decide if this needs to be addressed.

I have absolutely no idea if this matters. @zepumph - what say you?

@kathy-phet
Copy link

@KatieWoe said:

Safari on iPad seemed to have jumps/small lags when making the [Metacog] recording. I'll leave it to @jbphet and @zepumph to decide if this needs to be addressed.

I have absolutely no idea if this matters. @zepumph - what say you?

I would say to make an issue for this to track it, but to say "deferred", not RC blocking. We should investigate in situations where we know logging will occur, which is not the case at the moment.

@KatieWoe
Copy link
Contributor

Something odd I noticed, but was unable to reproduce:
I was testing the "preview html" feature on studio. I made the html file on the first screen (I thought), and when I loaded up the file, it opened on the second screen. I don't know if this was a bug, I copied something wrong, or I had a forgetful moment and really did make the file on the second screen. I haven't been able to reproduce. Leaving here for documentation.

@KatieWoe
Copy link
Contributor

State wrapper seems a bit laggy on old Mac 10.12 device.

@zepumph
Copy link
Member

zepumph commented Aug 13, 2020

State wrapper seems a bit laggy on old Mac 10.12 device.

I think this may fall into the same category as described in phetsims/states-of-matter#326 (comment). If these performance issues are blocking, we can potentially cherry-pick some improvements into the branch when those issue are marked as complete. But it seems like @kathy-phet may not think of them as blocking.

@KatieWoe
Copy link
Contributor

QA is done.

@KatieWoe KatieWoe assigned jbphet and unassigned KatieWoe Aug 13, 2020
@jbphet
Copy link
Contributor Author

jbphet commented Aug 14, 2020

Thanks @KatieWoe and team. I'll close this and will roll a new RC shortly, since all blocking issues have been addressed.

@jbphet jbphet closed this as completed Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants