-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC test: States of Matter 1.2.0-rc.1 #525
Comments
Given the aim of getting this sim to the client by mid-August this must be top priority in testing |
I wanted to note that, while the memory tests are fine, I did notice that a few devices were running a bit harder/fans were running more than I usually see. |
@KatieWoe said:
Is there a way that this can be quantified? I'd suggest running a test where the published version is run in an incognito Chrome window and the CPU usage measured using Windows task manager, then the same test is performed with the RC version. If the differences are measurable and significant, we can then decide if this warrants additional investigation. |
I would say to make an issue for this to track it, but to say "deferred", not RC blocking. We should investigate in situations where we know logging will occur, which is not the case at the moment. |
Something odd I noticed, but was unable to reproduce: |
State wrapper seems a bit laggy on old Mac 10.12 device. |
I think this may fall into the same category as described in phetsims/states-of-matter#326 (comment). If these performance issues are blocking, we can potentially cherry-pick some improvements into the branch when those issue are marked as complete. But it seems like @kathy-phet may not think of them as blocking. |
QA is done. |
Thanks @KatieWoe and team. I'll close this and will roll a new RC shortly, since all blocking issues have been addressed. |
@KatieWoe , @ariel-phet, @arouinfar, and @kathy-phet - states-of-matter/1.2.0-rc.1 is ready for RC testing. This includes both phet and phet-io brand and intended to be shared with a client in mid-August. Document issues in https://github.com/phetsims/states-of-matter/issues and link to this issue.
Assigning to @ariel-phet for prioritization.
General RC Test
What to Test
for a list of query parameters.)
spreadsheet and notify AR or AM if it not there.
there is a problem.
Focus and Special Instructions
Since the phet-io version is being shared with a client who intends to integrate it into a learning environment, the phet-io version should be thoroughly tested. Also, lots of under-the-hood changes have occurred, so the phet version should get a fair amount of scrutiny too.
Issues to Verify
These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.
Link(s)
PhET-iO RC Test
What to Test
sure the simulation loads without crashing or throwing errors.
Here's the link to the previous wrapper.
Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]
Issues to Verify
These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.
Link(s)
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: