Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom on interaction screen no longer line up with atom on the graph #277

Open
Tracked by #348
KatieWoe opened this issue May 15, 2020 · 10 comments
Open
Tracked by #348

Atom on interaction screen no longer line up with atom on the graph #277

KatieWoe opened this issue May 15, 2020 · 10 comments

Comments

@KatieWoe
Copy link
Contributor

Test device
Lovelace
Operating System
ChromeOS (and others)
Browser
Chrome
Problem description
For phetsims/qa#501. Incredibly nitpicky, and may just be something I thought was a design decision but wasn't. Please close if that is the case.
On the published version of the interaction screen, the center of the movable atom lined up vertically with the atom on the graph above it. In the dev version the graph has shifted and so they no longer line up. May be easier to see with a small atom in the adjustable option.

Visuals
Old:
old
New:
new

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪States of Matter‬
URL: https://phet-dev.colorado.edu/html/states-of-matter/1.2.0-dev.4/phet/states-of-matter_all_phet.html
Version: 1.2.0-dev.4 2020-05-07 23:42:25 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@arouinfar
Copy link
Contributor

Good find @KatieWoe! It was a deliberate design decision to align the movable atom and the position marker in the graph, so this looks like a bug to me.

@jbphet
Copy link
Contributor

jbphet commented May 20, 2020

This was a side effect of the removal of the zoom buttons, which was requested in #266.

@KatieWoe - please verify on master and unassign if it looks good, and we'll re-check as part of the next release process.

@KatieWoe
Copy link
Contributor Author

Looks much better to me

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Aug 4, 2020

This looks good in phetsims/qa#525. Closing

@KatieWoe KatieWoe closed this as completed Aug 4, 2020
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Aug 4, 2020

Will reopen if other issues found.

@KatieWoe KatieWoe reopened this Aug 5, 2020
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Aug 5, 2020

This actually seems to come back with long strings. The text to the left of the graph is smaller in that case and it shifts the graph to the left, but the atoms stay in the same place. Up to you @arouinfar and @jbphet if that is worth addressing. For phetsims/qa#525
shiftinggraph

@arouinfar
Copy link
Contributor

@KatieWoe
Copy link
Contributor Author

Also, that y-axis label looks a bit short to me?

@jbphet jbphet assigned jbphet and unassigned arouinfar Aug 12, 2020
@jbphet
Copy link
Contributor

jbphet commented Aug 13, 2020

This should be fixed as part of the 1.2 maintenance release after the initial 1.2 publication.

@jbphet
Copy link
Contributor

jbphet commented Aug 21, 2020

Unassigning until the maintenance release is designated as one of my priorities.

@jbphet jbphet removed their assignment Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants