-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom on interaction screen no longer line up with atom on the graph #277
Comments
Good find @KatieWoe! It was a deliberate design decision to align the movable atom and the position marker in the graph, so this looks like a bug to me. |
Looks much better to me |
This looks good in phetsims/qa#525. Closing |
Will reopen if other issues found. |
This actually seems to come back with long strings. The text to the left of the graph is smaller in that case and it shifts the graph to the left, but the atoms stay in the same place. Up to you @arouinfar and @jbphet if that is worth addressing. For phetsims/qa#525 |
Nice find @KatieWoe. In latest, the graph does not shift when the string shrinks, see: @jbphet can you look into this? |
Also, that y-axis label looks a bit short to me? |
This should be fixed as part of the 1.2 maintenance release after the initial 1.2 publication. |
Unassigning until the maintenance release is designated as one of my priorities. |
Test device
Lovelace
Operating System
ChromeOS (and others)
Browser
Chrome
Problem description
For phetsims/qa#501. Incredibly nitpicky, and may just be something I thought was a design decision but wasn't. Please close if that is the case.
On the published version of the interaction screen, the center of the movable atom lined up vertically with the atom on the graph above it. In the dev version the graph has shifted and so they no longer line up. May be easier to see with a small atom in the adjustable option.
Visuals
Old:
New:
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: States of Matter
URL: https://phet-dev.colorado.edu/html/states-of-matter/1.2.0-dev.4/phet/states-of-matter_all_phet.html
Version: 1.2.0-dev.4 2020-05-07 23:42:25 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: