Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressListener shows up as phetioFeatured in studio tree #601

Closed
arouinfar opened this issue Jun 23, 2020 · 4 comments
Closed

pressListener shows up as phetioFeatured in studio tree #601

arouinfar opened this issue Jun 23, 2020 · 4 comments

Comments

@arouinfar
Copy link
Contributor

Noticed while reviewing SOM for phetsims/states-of-matter#296.

I noticed that buttons and radio buttons now show the pressListener when viewing the featured elements in studio. None of the children are featured, so it looks like an empty container. Here are a few examples:

This doesn't seem like a particularly useful thing to be featured. Assigning the PhET-iO team for investigation.

Since this affects the upcoming client preview dev releases of SOM and GAO, I'm marking this as high priority. Apologies if this is the incorrect repo. Since I noticed this in buttons and radio buttons, sun seemed like the right place.

@samreid
Copy link
Member

samreid commented Jun 23, 2020

It looks like this is the same problem as https://github.com/phetsims/studio/issues/28, I'll copy the additional information there and close this issue.

@samreid samreid closed this as completed Jun 23, 2020
@arouinfar
Copy link
Contributor Author

@samreid I'm also questioning why the pressListener is featured in the first place. I do not remember seeing it being featured until recently.

@samreid
Copy link
Member

samreid commented Jun 23, 2020

The pressListener is not instrumented so it is neither phetioFeatured: true nor phetioFeatured: false. The fact that it is showing in the featured view in studio is a bug related to https://github.com/phetsims/studio/issues/28.

@samreid samreid assigned arouinfar and unassigned samreid Jun 23, 2020
@arouinfar
Copy link
Contributor Author

Got it, thanks for the explanation @samreid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants