Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: gravity-force-lab-basics:1.0.0-rc.2 #438

Closed
11 tasks done
zepumph opened this issue Oct 14, 2019 · 6 comments
Closed
11 tasks done

RC Test: gravity-force-lab-basics:1.0.0-rc.2 #438

zepumph opened this issue Oct 14, 2019 · 6 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Oct 14, 2019

@terracoda, @emily-phet, @jessegreenberg, gravity-force-lab-basics:1.0.0-rc.2 is ready for RC testing. This is the second RC test for this sim (see #429). This is being published for the first time, and includes sound as well as Interactive Descriptions. Document issues in https://github.com/phetsims/gravity-force-lab-basics/issues and link to this issue. There are many changes from the previous version, and a few were difficult to copy from master, so I would recommend testing a bit more thoroughly than just a a spot check here. Especially as it pertains to the descriptions.

Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Check this LoL spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version
  • If there is a console available, check for errors and include them in the Problem Description.

Issues to Verify

Instead of just issues, these are links directly to the comment which should have the instructions about what to verify:

This sim was also not included in some of the batch maintenance releases that recently went out, so please make sure these are fixed in this rc as well:

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is "status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)


Accessibility (a11y) RC Test

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature doesn't negatively affect the sim in any way.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).

Link(s)

Screen Readers

This sim supports screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to screen readers. If you simply need a refresher on screen readers, please consult the QA Book, which should have all of the information you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in this Google Document. If you find a screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a screen reader.

Final Requests


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ghost
Copy link

ghost commented Oct 14, 2019

Making top since we don't have anything else in the repo right now. (Except for issues that are languishing.)

@KatieWoe
Copy link
Contributor

@jonathanolson mentioned it, but #432 (comment) needs to be implemented here.

@ariel-phet
Copy link
Contributor

bumping down to high priority, since #432 is for fixes to broken sims that are "live" in the world.

@KatieWoe
Copy link
Contributor

#432 (comment) was not applied. That means that phetsims/phet-core#64 failed I believe

@KatieWoe
Copy link
Contributor

QA is done

@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2019

Thanks! We will proceed with a spot check rc over in phetsims/gravity-force-lab-basics#184 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants