Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depressed buttons on iOS 13 look wrong #526

Closed
KatieWoe opened this issue Sep 17, 2019 · 11 comments
Closed

Depressed buttons on iOS 13 look wrong #526

KatieWoe opened this issue Sep 17, 2019 · 11 comments
Assignees
@KatieWoe
Labels
priority:1-top

Comments

@KatieWoe
Copy link

For phetsims/qa#427. Not caused by that update however.
The image for the depressed button that starts a wave seems wrong on iOS 13. Also seen when depressing buttons such as reset all on any sim.
Image from iOS (1)
Image from iOS
@KatieWoe
Copy link
Author

Nevermind, not just this sim.

@KatieWoe KatieWoe transferred this issue from phetsims/wave-interference Sep 17, 2019
@jonathanolson
Copy link
Contributor

If there's something wrong with rendering, I'd also be worried that the bug would be present in desktop Safari. Do we have any betas for that?

@KatieWoe
Copy link
Author

I don't think we do, but I can take some time to try and get one.

@samreid
Copy link
Member

samreid commented Sep 19, 2019

This problem seems related to sun, so I'll transfer the issue there.

@samreid samreid transferred this issue from phetsims/phet-core Sep 19, 2019
@jonathanolson
Copy link
Contributor

This is live in a bad state on iOS 13 on my phone. Elevating the priority, investigating workarounds.

jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 19, 2019
@jonathanolson
Adding initial proof-of-concept for phetsims/sun#526
e5633d4
@jonathanolson
Copy link
Contributor

It looks like the general SVG and Canvas radial gradients with different start/end points are failing to display. This is also visible for https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Gradients where on iOS 13 it shows up badly:

IMG_1906

@jonathanolson
Copy link
Contributor

This has been noticed in https://bugs.webkit.org/show_bug.cgi?id=201390 a few days ago, is marked as a problem in a lower framework (which makes sense). I added a comment with my reproducible example.

@jessegreenberg jessegreenberg mentioned this issue Sep 19, 2019
Closed
@KatieWoe
Copy link
Author

@loganbraywork just suggested, and I checked, this does hit the app, including the Rutherford Scattering part.

jonathanolson added a commit to phetsims/rutherford-scattering that referenced this issue Sep 20, 2019
@jonathanolson
Concentric gradient workaround for phetsims/sun#526
4565241
jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 20, 2019
@jonathanolson
Safari workaround for radial gradient issue, see phetsims/sun#526
df95993
jonathanolson added a commit to phetsims/rutherford-scattering that referenced this issue Sep 20, 2019
@jonathanolson
Concentric gradient workaround for phetsims/sun#526
3acc9b8
jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 20, 2019
@jonathanolson
Safari workaround for radial gradient issue, see phetsims/sun#526
8bb54ba
jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 23, 2019
@jonathanolson
Safari workaround for radial gradient issue, see phetsims/sun#526
4101737
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Sep 23, 2019
@jonathanolson
updated dependencies.json for phetsims/sun#526
f1fd758
jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 23, 2019
@jonathanolson
Safari workaround for radial gradient issue, see phetsims/sun#526
4a65c37
jonathanolson added a commit to phetsims/area-builder that referenced this issue Sep 23, 2019
@jonathanolson
updated dependencies.json for phetsims/sun#526
d234f36
jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 23, 2019
@jonathanolson
Safari workaround for radial gradient issue, see phetsims/sun#526
21d09b1
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue Sep 23, 2019
@jonathanolson
updated dependencies.json for phetsims/sun#526
63ff5a1
jonathanolson added a commit to phetsims/scenery that referenced this issue Sep 23, 2019
@jonathanolson
Safari workaround for radial gradient issue, see phetsims/sun#526
237cca6
jonathanolson added a commit to phetsims/molecules-and-light that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.3.12, phetsims/sun#526
e43997f
jonathanolson added a commit to phetsims/molecules-and-light that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.4.13, phetsims/sun#526
114905a
jonathanolson added a commit to phetsims/neuron that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.1.17, phetsims/sun#526
53ff94f
jonathanolson added a commit to phetsims/ohms-law that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.4.6, phetsims/sun#526
7dff0fb
jonathanolson added a commit to phetsims/pendulum-lab that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.0.14, phetsims/sun#526
15ac43b
jonathanolson added a commit to phetsims/ph-scale that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.3.3, phetsims/sun#526
050ec57
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.3.3, phetsims/sun#526
0abf101
jonathanolson added a commit to phetsims/plinko-probability that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.1.17, phetsims/sun#526
7dcd2f3
jonathanolson added a commit to phetsims/projectile-motion that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.0.14, phetsims/sun#526
da5d55c
jonathanolson added a commit to phetsims/proportion-playground that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.0.14, phetsims/sun#526
7336d6a
jonathanolson added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.2.9, phetsims/sun#526
46b84cd
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.6.8, phetsims/sun#526
6be3956
jonathanolson added a commit to phetsims/states-of-matter that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.1.9, phetsims/sun#526
d890068
jonathanolson added a commit to phetsims/states-of-matter-basics that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.1.7, phetsims/sun#526
bc54eb4
jonathanolson added a commit to phetsims/trig-tour that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.0.21, phetsims/sun#526
5d98361
jonathanolson added a commit to phetsims/under-pressure that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.1.17, phetsims/sun#526
07e9905
jonathanolson added a commit to phetsims/unit-rates that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.0.16, phetsims/sun#526
cf82ca9
jonathanolson added a commit to phetsims/wave-interference that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.0.9, phetsims/sun#526
aa937c9
jonathanolson added a commit to phetsims/wave-on-a-string that referenced this issue Oct 3, 2019
@jonathanolson
Bumping version to 1.1.21, phetsims/sun#526
1c50712
@zepumph zepumph mentioned this issue Oct 14, 2019
Closed
11 tasks
SaurabhTotey pushed a commit to phetsims/curve-fitting that referenced this issue Oct 16, 2019
@jonathanolson
updated dependencies.json for phetsims/sun#526
32700c6
@ariel-phet
Copy link

@KatieWoe I assume if phetsims/qa#432 fixes the remaining platform, this issue can be closed

@KatieWoe
Copy link
Author

It looks like it does. I'll close as soon as everything is confirmed there

@KatieWoe
Copy link
Author

Looks good there

@SaurabhTotey SaurabhTotey mentioned this issue Nov 6, 2019
Closed
6 tasks
@jessegreenberg jessegreenberg mentioned this issue May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
priority:1-top
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jonathanolson @samreid @ariel-phet @arouinfar @KatieWoe