Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a screenshot #24

Closed
samreid opened this issue Jan 5, 2018 · 8 comments
Closed

Add a screenshot #24

samreid opened this issue Jan 5, 2018 · 8 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jan 5, 2018

In attempt to work around phetsims/perennial#64 I'm copying the gravity force lab screenshot to assets/ for a build. But we will need to generate an accurate screenshot for this sim. I'm not sure if the sim is ready for that yet, so I'll mark this as high priority (so it isn't neglected) but leave unassigned for now.

@samreid
Copy link
Member Author

samreid commented Jan 5, 2018

We can remove the placeholder image if/when phetsims/perennial#64 is resolved

@arouinfar
Copy link
Contributor

Let's go with something like this @phet-steele
image

Alternates:
image

screen shot 2018-01-22 at 1 57 49 pm

@arouinfar arouinfar assigned phet-steele and unassigned arouinfar Jan 22, 2018
@phet-steele phet-steele assigned ghost and unassigned phet-steele May 10, 2018
@jessegreenberg
Copy link
Contributor

@phet-steele @lmulhall-phet do you know why this is on hold? Maybe because the mass colors have changed since #24 (comment)?

@arouinfar
Copy link
Contributor

@jessegreenberg my guess is that screenshot issues are generally put on-hold until a sim reaches RC, at which point there aren't likely to be any further design tweaks.

That said, I would still go with these screenshots, albeit taken from the latest version.

@ghost
Copy link

ghost commented Jul 17, 2018

Yeah, we usually try to take screenshots right after we're done with the last round of RC.

@ghost ghost assigned KatieWoe Jul 20, 2018
@ghost ghost removed their assignment Jul 24, 2019
@zepumph
Copy link
Member

zepumph commented Oct 15, 2019

Yeah, we usually try to take screenshots right after we're done with the last round of RC.

We are around that time, as RC.2 is in QA right now. I'm going to remove the on-hold label, though it may not be necessary just this second.

@KatieWoe
Copy link
Contributor

Screenshots updated using phetsims/qa#438. @arouinfar please close if you are happy with results.

@KatieWoe KatieWoe assigned arouinfar and unassigned KatieWoe Oct 15, 2019
@zepumph zepumph mentioned this issue Oct 17, 2019
@arouinfar
Copy link
Contributor

Thanks @KatieWoe. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants