Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot Check: Gravity Force Lab Basics 1.0.0-rc.3 #441

Closed
zepumph opened this issue Oct 17, 2019 · 4 comments
Closed

Spot Check: Gravity Force Lab Basics 1.0.0-rc.3 #441

zepumph opened this issue Oct 17, 2019 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Oct 17, 2019

Previous RC: #438

@terracoda, @emily-phet, @jessegreenberg, gravity-force-lab-basics:1.0.0-rc.3 is ready for RC testing.

This is the third RC test. Nothing was found during last RC testing save potential issues with some MR patches that our release here has been interfering with. @KatieWoe please make sure that the appropriate patches for the MR being done and tested over in #432 (comment).

You already mentioned that in #438 (comment)

I have been pretty far out of the loop in terms of the MRs, and only getting a list of patches to make sure to include in releases. Please forward questions about that behavior to @jonathanolson.

For the sim specific stuff, there really isn't any. Please just make sure that it isn't broken, especially when using a screen reader, and with mobile + VO.

@jessegreenberg feel free to recommend further testing if you feel like it is needed.

Folder:
https://phet-dev.colorado.edu/html/gravity-force-lab-basics/1.0.0-rc.3/phet/

Sim:
https://phet-dev.colorado.edu/html/gravity-force-lab-basics/1.0.0-rc.3/phet/gravity-force-lab-basics_all_phet.html

@ariel-phet please assign and prioritize.

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 18, 2019

  • Win 10 chrome (with and without Jaws)
  • Win 10 firefox (with and without NVDA)
  • Win 10 edge

  • Mac 10.15 chrome
  • Mac 10.15 firefox
  • Mac 10.15 safari (with and without VO)

  • Win 7 IE
  • Mac 10.11 safari

  • ChromeOS
  • iPadOS 13 (with and without VO)

@zepumph to approve test devices

@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2019

Looks good to me, thanks!

@KatieWoe
Copy link
Contributor

QA is done

@KatieWoe KatieWoe assigned zepumph and unassigned KatieWoe Oct 22, 2019
@zepumph
Copy link
Member Author

zepumph commented Oct 22, 2019

Thanks! We will work out phetsims/gravity-force-lab-basics#185 and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants