Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPadOS 13 Checkboxes won't select/deselect with VO #176

Closed
KatieWoe opened this issue Sep 23, 2019 · 12 comments
Closed

iPadOS 13 Checkboxes won't select/deselect with VO #176

KatieWoe opened this issue Sep 23, 2019 · 12 comments

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#429
I was checking VO on iPadOS Beta since it will be coming out soon. I was unable to check and uncheck boxes (Force Values, Distance, and Constant Size). When attempting to double tap to do so, it would instead seem to activate the pink keyboard focus box and both it and the iPad's focus could be seen over the box. Repeated attempts might cause it to read the box's description again, but it would not check or uncheck the box. It seemed to work as expected in iOS 12.

@zepumph
Copy link
Member

zepumph commented Sep 23, 2019

Assigning @jessegreenberg for assistance. Do you have a way to test this or reproduce it? I think we also may want to move this issue out of GFLB depending on its severity.

@jessegreenberg
Copy link
Contributor

I confirmed it is working as expected in iOS 12. Ill see if I can get iOS 13 to test.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Sep 23, 2019

I have an iPad Air 2, https://www.apple.com/ipados/ says that will be compatible. I am not sure how getting the beta works but iPadOS comes out tomorrow, Ill take a look then.

@zepumph
Copy link
Member

zepumph commented Sep 24, 2019

Good luck!

@terracoda
Copy link

Is the iOS on iPad different from iOS on the iPhone?
I can check and uncheck checkboxes on iPhone 7 with iOS 12.4.1
Unfortunately, I haven't upgraded yet, so not sure how useful my test is.

@KatieWoe
Copy link
Contributor Author

It is as of today's apple update.

@KatieWoe
Copy link
Contributor Author

Not sure what it looks like on iOS 13 on iPhone.

@jessegreenberg
Copy link
Contributor

OK, I confirmed that the checkbox cannot be checked in iPadOS13 while the cursor is on the checkbox. However, if the cursor is on the checkbox label, the checkbox can be checked correctly. Ill see if this is true for native HTML

@jessegreenberg
Copy link
Contributor

https://jsfiddle.net/Lbnu98xq/ works OK.

It looks like the HTML checkboxes are not sized to overlap the entire Node with label:
image

In chrome, the box takes up the entire text like this
image

Guessing width isn't being set correctly. Moving to scenery because I think this involves styling of PDOM elements.

@terracoda
Copy link

In comment phetsims/scenery#1001 (comment), @jessegreenberg has a solution, though it may be "fragile".

@zepumph, do we need to do another RC to test this out?

@zepumph
Copy link
Member

zepumph commented Oct 7, 2019

@terracoda we will definitely want another RC for this. The commits over in phetsims/scenery#1001 will be cherry picked to the branch. Then we will have QA look at this.

@KatieWoe
Copy link
Contributor Author

Issue seems solved. Checked by @loganbraywork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants