Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should get "closest" alert when closest with a constant radius #183

Closed
zepumph opened this issue Oct 8, 2019 · 5 comments
Closed

Should get "closest" alert when closest with a constant radius #183

zepumph opened this issue Oct 8, 2019 · 5 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Oct 8, 2019

Will be needed for #179

@zepumph zepumph self-assigned this Oct 8, 2019
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 8, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. phetsims/gravity-force-lab-basics#183
zepumph added a commit that referenced this issue Oct 8, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. #183
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Oct 8, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. phetsims/gravity-force-lab-basics#183
zepumph added a commit to phetsims/coulombs-law that referenced this issue Oct 8, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. phetsims/gravity-force-lab-basics#183
@zepumph
Copy link
Member Author

zepumph commented Oct 8, 2019

This was added to master in the above commit by making the constant sized radius the same as the min mass radius in GFLB. I should add this to the release branch.

QA when you get to this, the way to make sure that this made it into the rc is to make sure that when the masses are closest to each other, and you try to move one step closer (but you can't), the alert should start with "Closest" and not "Extremely close". This should be the case with or without constant sized checked.

@zepumph
Copy link
Member Author

zepumph commented Oct 14, 2019

Cherrypick
phetsims/gravity-force-lab@dbc5b5b
f539a48
phetsims/inverse-square-law-common@6c3c3a0

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Oct 14, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. phetsims/gravity-force-lab-basics#183
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Oct 14, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. phetsims/gravity-force-lab-basics#183
@zepumph
Copy link
Member Author

zepumph commented Oct 14, 2019

QA: to test this, make the masses have a constant radius and the smallest mass, and then move them as close as possible. Afterward, try to move them one step closer, and the alert you get should start with "closest" instead of "extremely close" as would happen if the masses were a bit larger (without constant size checked).

@zepumph zepumph removed their assignment Oct 14, 2019
zepumph added a commit that referenced this issue Oct 14, 2019
…nd Charge to es6, removing ISLCObject.calculateRadius abstract method. #183
@KatieWoe
Copy link
Contributor

When testing at least NVDA that there could be a noticeable pause before the dialog was read out, but it seemed to work well beyond that.

@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2019

That is expected and purposeful. We create that pause artificially to make sure there aren't too many alerts. This has be put in front of users and tested. We can open up new issues if we find that is problematic. Thanks @KatieWoe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants