Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO review for 1.6 release #440

Closed
3 tasks done
arouinfar opened this issue Sep 19, 2022 · 1 comment
Closed
3 tasks done

PhET-iO review for 1.6 release #440

arouinfar opened this issue Sep 19, 2022 · 1 comment

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Sep 19, 2022

This was one of the earliest sims published with PhET-iO Studio, and I think it would benefit from another design review before the upcoming publication of 1.6.

Review will focus on:

  • Review dynamic strings/layout behavior
  • Verify stringProperties are linked appropriately in the view
  • Review phetioFeatured elements, and update overrides as needed
@arouinfar
Copy link
Contributor Author

I completed the design review and opened a few issues tagged above.

I also updated the phetioFeatured overrides in the above commit. Summary of the changes:

  • Featured zoomLevelProperty to be consistent with other sims.
  • Unfeatured massSlider.visibleProperty because clients should use the top-level visibleProperty instead.
  • Found a few cases where a Property should have been featured for all bodies, but skipped over by accident once or twice (e.g. isCollidedProperty, velocityProperty).
  • Featured measuringTape.endPointProperty & measuringTape.startPointProperty on the To Scale screen because clients may want to know the coordinates of the measuring tape and compare to the positionPropertyof the bodies in the Play Area.
  • Featured formattedTimeProperty so clients have easier access to the time using the units in the view, such as Earth Days. (Model time is featured too, but it's always in seconds.)
  • Featured timeControlNode.playPauseStepButtonGroup.visibleProperty to keep things consistent with timeControlNode.speedRadioButtonGroup.visibleProperty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant