Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Objects button needs a maxWidth #439

Closed
Tracked by #841
arouinfar opened this issue Sep 19, 2022 · 4 comments
Closed
Tracked by #841

Return Objects button needs a maxWidth #439

arouinfar opened this issue Sep 19, 2022 · 4 comments
Assignees
@KatieWoe
Labels
status:ready-for-review type:i18n

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Sep 19, 2022 •
edited
Loading

For #440

@samreid the Return Objects button doesn't have a maxWidth, as revealed by editing the returnObjectsStringProperty.

image.

This problem exists in the latest published version of the sim, but stringTest=long isn't long enough to reveal the layout issues, so it's flown under the radar for a while now.
samreid added a commit that referenced this issue Sep 26, 2022
@samreid
Specify maxWidth, see #439
4330957
@samreid
Copy link
Member

samreid commented Sep 26, 2022

Fixed and ready for review, thanks.

@samreid samreid assigned arouinfar and unassigned samreid Sep 26, 2022
@arouinfar
Copy link
Contributor Author

@samreid this looks fixed in master, but I'm not seeing the change in rc.1. Seems like something that will need cherry-picking.
image

@arouinfar arouinfar assigned samreid and unassigned arouinfar Sep 29, 2022
@samreid
Copy link
Member

samreid commented Oct 6, 2022

Needed for phetsims/qa#841

samreid added a commit that referenced this issue Oct 6, 2022
@samreid
Specify maxWidth, see #439
7001615
@samreid samreid assigned KatieWoe and unassigned samreid Oct 6, 2022
@KatieWoe KatieWoe mentioned this issue Oct 6, 2022
Closed
24 tasks
@Nancy-Salpepi
Copy link

Return objects button has a max width in RC.3
Screen Shot 2022-10-06 at 1 38 28 PM

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
status:ready-for-review type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @arouinfar @KatieWoe @Nancy-Salpepi