Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

massesControlPanel should resize dynamically #444

Closed
Tracked by #841
arouinfar opened this issue Sep 21, 2022 · 4 comments
Closed
Tracked by #841

massesControlPanel should resize dynamically #444

arouinfar opened this issue Sep 21, 2022 · 4 comments
Assignees
@KatieWoe
Labels
dev:phet-io status:ready-for-review

Comments

@arouinfar
Copy link
Contributor

For #440

The massesControlPanel does not resize dynamically when its contents are hidden. The controlPanel resizes, so this seems like an oversight.

image
samreid added a commit that referenced this issue Sep 26, 2022
@samreid
Reflow massesControlPanel when children visibility change, see #444
ca9df62
@samreid
Copy link
Member

samreid commented Sep 26, 2022

Fixed and ready for review.

@samreid samreid assigned arouinfar and unassigned samreid Sep 26, 2022
@arouinfar
Copy link
Contributor Author

Thanks @samreid. Looks good in master, but not in rc.1, so tagging for cherry-picking.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Sep 29, 2022
@samreid
Copy link
Member

samreid commented Oct 6, 2022

Needed for phetsims/qa#841

samreid added a commit that referenced this issue Oct 6, 2022
@samreid
Reflow massesControlPanel when children visibility change, see #444
0d70af3
@samreid samreid assigned KatieWoe and unassigned samreid Oct 6, 2022
@KatieWoe KatieWoe mentioned this issue Oct 6, 2022
Closed
24 tasks
@Nancy-Salpepi
Copy link

This looks good in RC.3! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @arouinfar @KatieWoe @Nancy-Salpepi