Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controlPanel.visibleProperty and massesControlPanel.visibleProperty should not be read-only #443

Closed
arouinfar opened this issue Sep 19, 2022 · 2 comments
Closed

controlPanel.visibleProperty and massesControlPanel.visibleProperty should not be read-only #443

arouinfar opened this issue Sep 19, 2022 · 2 comments
Assignees
@arouinfar
Labels
dev:phet-io status:ready-for-review

Comments

@arouinfar
Copy link
Contributor

For #440

In master, controlPanel.visibleProperty and massesControlPanel.visibleProperty are phetioReadOnly: true, which is a deviation from the behavior in the lastest published version. @samreid can you switch these back to phetioReadyOnly: false?
samreid added a commit that referenced this issue Sep 21, 2022
@samreid
Mark controlPanel and massesControlPanel visibleProperty as readOnly:…
8da6cfa 
… false, see #443
@samreid
Copy link
Member

samreid commented Sep 21, 2022

Fixed, can you please spot check on phettest?

@samreid samreid assigned arouinfar and unassigned samreid Sep 21, 2022
@arouinfar
Copy link
Contributor Author

Thanks, looks good @samreid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @arouinfar