Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused string keys #438

Closed
Tracked by #841 ...
arouinfar opened this issue Sep 19, 2022 · 10 comments
Closed
Tracked by #841 ...

Unused string keys #438

arouinfar opened this issue Sep 19, 2022 · 10 comments
Assignees
Labels

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Sep 19, 2022

For #440

When reviewing the strings in Studio, I realized that there are two unused string keys -- earthDayStringProperty & earthMinuteStringProperty. These are both singular versions of the timeCounter string, however, only the plural version is ever used in the sim.
image image

@samreid can you confirm if these string keys are being used somewhere in the sim? If not, can we get rid of them?

@samreid
Copy link
Member

samreid commented Sep 26, 2022

I fixed this code and it should now be using the singular strings.

image

@arouinfar can you please review?

@arouinfar
Copy link
Contributor Author

Thanks @samreid. Looks good in master, but not in rc.1, so tagging for cherry-picking.

@samreid
Copy link
Member

samreid commented Oct 6, 2022

Needed for phetsims/qa#841

@Nancy-Salpepi
Copy link

The singular strings have been added to RC.3. Keeping this issue open because of #463.

@samreid
Copy link
Member

samreid commented Oct 7, 2022

We pushed a fix in #463 and @marlitas and I confirmed the strings are correctly omitted. Leaving open for verification in RC after cherry-picking the commits from #463

@samreid
Copy link
Member

samreid commented Nov 9, 2022

Please close after verifying.

@KatieWoe
Copy link
Contributor

This seems to be broken again in phetsims/qa#850
notfixed2
notfixed

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Nov 10, 2022
@Nancy-Salpepi
Copy link

@KatieWoe they decided to always go back to always plural because of #463

@samreid
Copy link
Member

samreid commented Nov 10, 2022

From discussion with @KatieWoe

image

@samreid samreid assigned KatieWoe and unassigned samreid Nov 11, 2022
@KatieWoe
Copy link
Contributor

Closing. Looks ok in RC 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants