-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused string keys #438
Comments
I fixed this code and it should now be using the singular strings. @arouinfar can you please review? |
Thanks @samreid. Looks good in master, but not in rc.1, so tagging for cherry-picking. |
Needed for phetsims/qa#841 |
The singular strings have been added to RC.3. Keeping this issue open because of #463. |
Please close after verifying. |
This seems to be broken again in phetsims/qa#850 |
From discussion with @KatieWoe |
Closing. Looks ok in RC 4 |
For #440
When reviewing the strings in Studio, I realized that there are two unused string keys --
earthDayStringProperty
&earthMinuteStringProperty
. These are both singular versions of the timeCounter string, however, only the plural version is ever used in the sim.@samreid can you confirm if these string keys are being used somewhere in the sim? If not, can we get rid of them?
The text was updated successfully, but these errors were encountered: