-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time display looks jumpy #463
Comments
@arouinfar how do you want to address this? Should the text be left aligned? Do you just want it to say "1 Earth Days"? I'm not sure of a robust way to make sure the "1 Earth day" has the same left coordinate as "2 Earth days". Keep in mind our solution needs to be robust against locale changes and phet-io text customization. |
Fixed and ready for cherry-picking. |
Please close after verifying. |
Looks good in 1.6.0-rc.4. Closing. |
Test device
MacBook Air (m1 chip)
Operating System
macOS 12.6
Browser
safari 16.0
Problem description
For phetsims/qa#841, I noticed that the grammar was fixed for the time displayed (1 earth day instead of days or 1 earth minute instead of minutes) between RC.2 and RC.3. This makes the time look a little jumpy when you first press Play. I was wondering if there is anything that can be done to prevent the entire time from shifting when an 's' is added/removed?
Visuals
time.jumpy.mp4
The text was updated successfully, but these errors were encountered: