[feature/fp-series-2] File Provider improvements #167

felix-schwarz · 2018-11-26T09:29:35Z

Description

Further improvements to the file provider.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

CLAassistant · 2018-11-26T09:29:44Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov · 2018-11-26T10:01:30Z

Codecov Report

Merging #167 into master will increase coverage by 0.54%.
The diff coverage is 46.37%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   48.43%   48.98%   +0.54%     
==========================================
  Files          99       98       -1     
  Lines        8178     8207      +29     
==========================================
+ Hits         3961     4020      +59     
+ Misses       4217     4187      -30

Impacted Files	Coverage Δ
...Client/Actions/Actions+Extensions/MoveAction.swift	`11.42% <0%> (-2.37%)`	⬇️
ownCloud/Theming/Resources/ThemeResource.swift	`33.33% <0%> (ø)`	⬆️
ownCloud/AppDelegate.swift	`87.03% <0%> (ø)`	⬆️
...ient/Actions/Actions+Extensions/RenameAction.swift	`8.88% <0%> (+0.37%)`	⬆️
...ient/Actions/Actions+Extensions/OpenInAction.swift	`10% <0%> (-0.26%)`	⬇️
...nagement/CertificateManagementViewController.swift	`0% <0%> (ø)`	⬆️
ownCloud/Viewer/DisplayHostViewController.swift	`0% <0%> (ø)`	⬆️
...t/Actions/Actions+Extensions/DuplicateAction.swift	`11.42% <0%> (+0.9%)`	⬆️
...d/UIKit Extensions/UIAlertController+OCIssue.swift	`0% <0%> (ø)`	⬆️
ownCloud/Client/Actions/MoreViewHeader.swift	`0% <0%> (ø)`	⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ceb9f...6e6f563. Read the comment docs.

jesmrec · 2018-11-26T12:12:50Z

After first Files App iteration, some pending stuff (improvements) and new features to be posted here:

(1) Save new doc [feature/fileprovider] File Provider support #67 (comment)
(2) [feature/fileprovider] File Provider support #67 (comment)
(3) Refresh after adding second account of the same server (not easy to reproduce) [feature/fileprovider] File Provider support #67 (comment)

- Fix Swift Lint warnings in new UI testing code

kopischke · 2018-12-04T16:24:13Z

Is this the right place to report issues with the file provider / Files app integration in the current TestFlight build, or is there a preferred channel?

jesmrec · 2018-12-04T16:41:56Z

@kopischke here is the right place. Post your comment or issue, and we will track the progress and status here: #167 (comment)

kopischke · 2018-12-05T17:37:01Z

I have the following issues to report with the current TestFlight version of ownCloud (build 85):

The system directory picker is unusable due to something I would call collapsing tremors: whenever you expand a directory hierarchy, the expanded hierarchy almost immediately collapses again. Difficult to describe properly, but this video shows it quite well. Try saving a file from an app supporting the iOS document management model to an ownCloud server, you’ll see what I mean.
Files app occasionally refuses to display the contents at the root of the ownCloud server. Bit of a Heisenbug, I am afraid to say, but very much real:
.
Downloads triggered in Files app stall: the download progress circle appears, and the ownCloud app shows a download has been requested in the UI, but the file is not downloaded in any reasonable amount of time (speaking of 15 minutes and more for 70 Kb PDFs over a high bandwidth non-mobile connection).
ownCloud folders marked as Favourites disappear from the Files app sidebar after Files is purged from memory. They are still marked as Favourites (the long press context menu offers a non-functional Unfavourite option), but are not shown in the sidebar. This is a common issue in several file providers I have used; the only ones I am aware of that do not suffer from this issue are iCloud, Dropbox and Working Copy (since the most recent release, according to the release notes; Anders Borum may be open to sharing his secret sauce 😉).

felix-schwarz · 2018-12-06T09:02:33Z

@kopischke Thanks for reporting these issues! To get a better idea on where to look, if you have some time, answers to these questions would help me a great deal:

Regarding issue 1: are the folders shown in the video frequently updated by multiple users - f.ex. while someone else modifying a file while you're trying to select a folder?

Regarding issue 2: is this to a local or a remote server?

Regarding issue 3: does this happen for all files, right away? Or only after some other operation seemingly didn't succeed? Does re-creating the bookmark solve the issue?

Regarding issue 4: Thanks for reporting! This is likely a side effect of the File Provider not yet providing a Working Set to the Files app (which expects to find all favorited items in that).

Thanks!

- maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus

- Updated to latest SDK

- App now logs current log settings at launch

…reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others

… make sure it's only built, linked to and copied in the ownCloudTests target

kopischke · 2018-12-11T20:02:32Z

@kopischke Thanks for reporting these issues! To get a better idea on where to look, if you have some time, answers to these questions would help me a great deal:

Yeah, sure, and sorry for the delay.

Regarding issue 1: are the folders shown in the video frequently updated by multiple users - f.ex. while someone else modifying a file while you're trying to select a folder?

Shared with and occasionally updated by other users, yes. Not at the time I encountered the issue, no (to my best knowledge). However, we also access the same instance via Webdrive on our desktop machines; these may be polling (but should not be updating anything) rather aggressively…

Regarding issue 2: is this to a local or a remote server?

Remote (large ownCloud instance managed on behalf of several German universities).

Regarding issue 3: does this happen for all files, right away? Or only after some other operation seemingly didn't succeed? Does re-creating the bookmark solve the issue?

All files, right away, independently of if I start the download in Files or in the ownCloud app (the status feedback is consistent across both apps, but the net effect is stalling). Not sure what you mean by “re-creating the bookmark”.

Regarding issue 4: Thanks for reporting! This is likely a side effect of the File Provider not yet providing a Working Set to the Files app (which expects to find all favorited items in that).

Can’t comment on that, but I would be glad to see the issue solved: the ownCloud instance I use is my main work cloud, so Favourites are a much needed feature.

- Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off

- Updated SDK fixing a lot of issues

…dded OnMainThread(after: timeInterval)

…received by iOS and the results that were returned

jesmrec · 2019-01-21T13:42:11Z

About the sanity check performed to Files App (208733c):

Issues from the first PR of Files App support, mentioned above ([feature/fp-series-2] File Provider improvements #167 (comment)):
- (1) : still reproducible
- (2): file is uploaded, but no progress is shown to the user, so it is not easy to know what is going on till the upload finished. Not sure is something could be done here because the action is done completely inside Files App.
- (3) is fixed
[Files app] Clicking both "Done" buttons at folder creation breaks the Files app #221 is still reproducible
Batched uploads are not too stable when the number of files is high (Batch Uploads #224). Also i tried to upload a huge file together with the bunch of small files, and the app becomes stucked.
If the server is down (not the network), app gets stucked

felix-schwarz · 2019-01-22T08:52:56Z

About the sanity check performed to Files App (208733c):

Issues from the first PR of Files App support, mentioned above (#167 (comment)):

(1) : still reproducible

I tried with Pages and could (partially) reproduce it: the template I chose was uploaded to the ownCloud server, but when I made changes and tried to save them, I got an error "file does not exist".

The underlying issue seems to be that iOS / Pages expects that it can keep writing to the location that was returned from the File Provider's importDocumentAtURL: method.

Right now, the OC FileProvider returns a placeholder item here, so the location of the file is ../files/_placeholder_RANDOM_UUID/Example.pages. Paths follow the ../files/FILE_ID/ pattern.

Once the upload is finished, the placeholder item is replaced by the actual item on the server, but this also changes the location of the file to ../files/FILE_ID_FROM_OWNLOUD/Example.pages on the device.

If the upload finishes before the app writes changes, ../files/_placeholder_RANDOM_UUID/Example.pages is gone and iOS / Pages brings up the "File does not exist" alert.

Possible solutions:

Only return from the importDocumentAtURL: once the upload has actually finished. Being just a two-liner, I tried this and it works, but it effectively prevents creating new documents when offline, because Pages / iOS waits for the FileProvider to return before actually open a new document for editing.
Preserve the placeholder location and track it along the finished item. This would add a lot of complexity to the Sync Engine going forward, though. A possibility, but not my favorite.
Allow the app to create its own FileID and have the server use it. This way, the placeholder location would also be the location of the uploaded item, because the FileID doesn't change. Unless this is already supported by the server, this would require adding support for such a feature to the server.

(2): file is uploaded, but no progress is shown to the user, so it is not easy to know what is going on till the upload finished. Not sure is something could be done here because the action is done completely inside Files App.

I'm not sure what's causing this as the FileProvider provides the necessary information to iOS. From what I have been able to observe, progress information is most likely available when doing uploads inside the Files app itself.

(3) is fixed

[Files app] Clicking both "Done" buttons at folder creation breaks the Files app #221 is still reproducible

I have not been able to reproduce this with 208733c . Please send me a log so I can have a look.

Batched uploads are not too stable when the number of files is high (Batch Uploads #224). Also i tried to upload a huge file together with the bunch of small files, and the app becomes stucked.

Likewise, please also send me a log for this.

If the server is down (not the network), app gets stucked

And another log for this, too :)

…ith the placeholder, but only when upload has completed - and then return the final item

felix-schwarz · 2019-01-22T09:19:29Z

@jesmrec I just pushed 6a5581d that implements possible solution 1.

jesmrec · 2019-01-22T10:12:43Z

Let's go for some tests with 6a5581d

Batched uploads: with a small amount of files works properly. I repeated the process with the 330 files and the log is the following (from XCode, if you need something else, tell me). Here, i noticed that te process do not start (my first report was about not finishing). seems to be any problem reated with the file thumbnails fetching.

batchuploads.txt

Server down: i opened a separate issue (Server down #230). In any case, here it is the log. With the server down, i tried to delete a file:

serverdown.txt

felix-schwarz · 2019-01-22T10:23:46Z

@jesmrec After discussing the issue with @DeepDiver1975, we came to the conclusion that option 3 is not possible. So we have option 1 implemented in
6a5581d for now, but will eventually have to find an efficient way to do option 2.

jesmrec · 2019-01-22T12:08:23Z

option 1 is working fine in 6a5581d.

mneuwert · 2019-01-22T20:13:13Z

ownCloud File Provider/FileProviderExtension.m

@@ -45,20 +45,57 @@ - (instancetype)init
 	OCAppIdentity.sharedAppIdentity.appGroupIdentifier = bundleInfoDict[@"OCAppGroupIdentifier"];

 	if (self = [super init]) {
-		_fileManager = [[NSFileManager alloc] init];
+		_fileManager = [NSFileManager new];


@felix-schwarz I find alloc / init more explicit but it's a matter of personal preference I guess

Until recently, I used to be in the alloc / init camp, too. But since I started writing more and more Swift code, alloc / init reminded me of allocWithZone: and felt outdated. FWIW new has also been around since macOS 10.0. It really boils down to personal preference as you say. :)

mneuwert · 2019-01-22T20:23:21Z

ownCloud/Client/Actions/MoreViewHeader.swift

@@ -100,19 +100,13 @@ class MoreViewHeader: UIView {
 			labelContainerView.bottomAnchor.constraint(lessThanOrEqualTo: self.safeAreaLayoutGuide.bottomAnchor, constant: -20)
 		])

-		titleLabel.attributedText = NSAttributedString(string: item.name, attributes: [NSAttributedString.Key.font: UIFont.systemFont(ofSize: 17, weight: .semibold)])
+		titleLabel.attributedText = NSAttributedString(string: item.name ?? "", attributes: [NSAttributedString.Key.font: UIFont.systemFont(ofSize: 17, weight: .semibold)])


@felix-schwarz minor complain.. magic number 17 could be replaced with constant. Would make sense if this font size is used in other places..

I totally agree. The Theme-system in the app should also provide styles like this, but this is outside the scope of the file provider. I see an opportunity to standardize these styles alongside making other Theme changes in feature/branded-login (#168).

@mneuwert

* - Minor memory optimizations - Updated to latest SDK * - Save changes prior to merge with master * - Convert to Swift 4.2 * - Further Swift 4.2 changes * - Update to latest SDK develop commit * - Adapting APP to latest SDK changes - maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus * - Added back ownCloudUI.framework to copy phase of ownCloud target - Updated to latest SDK * - Add support for OCLogToggle in Settings - App now logs current log settings at launch * - Fix issues in ClientQueryViewController related to UITableView not reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others * - Remove last traces of OCMocking.framework from ownCloud app target, make sure it's only built, linked to and copied in the ownCloudTests target * - Fix EarlGrey/CocoaPods workspace / build errors * - Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension * - Update SDK * - Remove superfluous [FP] from log message * - Make sure DisplayViewController uses the updated version of an item after downloading it instead of the (now) outdated original version * - Update to latest SDK * - Fixing thumbnail aspect ratio and removing duplicate code in NamingViewController (#141) * - Update SDK * - Exit editing mode in the server list when the user selects an existing or adds a new bookmark (as reported by @mneuwert) * - Adapt app code base to change in OCError Swift conversion (following OCErrorAuthorizationCancelled typo correction) * - Fix #152: if the user cancels OAuth2, an error is no longer shown (and errors are better to read with recent SDK updates) * - Update to latest SDK * - Make ProgressSummarizer only consider Progress objects with descriptions, resolving "ghost" progress bars without any information in them * - Adapt to change of name of OCConnectionIssue to OCIssue * - Update to latest SDK - ConnectionIssueViewController - added option to provide a block to be called when dismissal has finished - normalize code formatting - UIAlertController+OCIssue - added option to provide a completionHandler that's called when the user made a choice - ClientRootViewController - switched issue and alert presentation to use a AsyncSequentialQueue to present them in order and not on top of each other - fixed a bug where a UIViewController that's in the process of being dismissed led to a failure to present alerts and issues * - Make DisplayViewController use OCCoreOptionReturnImmediatelyIfOfflineOrUnavailable and fix a typo (#179) * - Added priority summaries to ProgressSummarizer - Fixed a crash bug in ImageDisplayViewController - Removed core connection status interpretation from ClientQueryViewController - Added core connection status tracking to ClientRootViewController and utilize priority summaries to display offline or server in maintenance mode status messages * - Fix an issue where "Offline." was shortly shown when logging in - Switch to utilizing short connection status descriptions coming straight from the SDK's connection signal providers - Adapt Localizable.strings accordingly * - Add *.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist to .gitignore * - Updated ios-sdk * - Made FileProviderEnumerator use an OCQuery that includes the root item (fixes #203) - Made FileProviderExtension observe the domain property and trigger an initial query of the root directory when none has even been done before (fixes #205) * - Adapted to latest round of nullability additions in the SDK - Fixing potential crash bugs in DisplayHostViewController, ConnectionIssueViewController, SortMethod and others - Update actions - make use of .completed() instead of calling the completionHandler directly - fixing multi-item support for several actions (completionHandler would previously get executed once for every item instead of once) - ClientDirectoryPickerViewController now calls the completinHandler even on cancelation - Cleaned up OCIssue+Extension and OCItem+Extension - Replacing AsyncSequentialQueue with OCAsyncSequentialQueue * - Update SDK * - Updated ios-sdk * - Update ios-sdk with IPC fixes * - Adapt tests to SDK changes (all tests pass) - Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off * - Present cache contents while waiting for a reply from the server - Updated SDK fixing a lot of issues * - Replacing DispatchQueue.main.async* with OnMainThread and a newly added OnMainThread(after: timeInterval) * - Add verbose logging to FileProviderExtension to track the commands received by iOS and the results that were returned * - Temporary workaround: make importFileFromURL: not return directly with the placeholder, but only when upload has completed - and then return the final item * - Switching ios-sdk to updated master branch

@mneuwert

* - Minor memory optimizations - Updated to latest SDK * - Save changes prior to merge with master * - Convert to Swift 4.2 * - Further Swift 4.2 changes * - Update to latest SDK develop commit * - Adapting APP to latest SDK changes - maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus * - Added back ownCloudUI.framework to copy phase of ownCloud target - Updated to latest SDK * - Add support for OCLogToggle in Settings - App now logs current log settings at launch * - Fix issues in ClientQueryViewController related to UITableView not reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others * - Remove last traces of OCMocking.framework from ownCloud app target, make sure it's only built, linked to and copied in the ownCloudTests target * - Fix EarlGrey/CocoaPods workspace / build errors * - Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension * - Update SDK * - Remove superfluous [FP] from log message * - Make sure DisplayViewController uses the updated version of an item after downloading it instead of the (now) outdated original version * - Update to latest SDK * - Fixing thumbnail aspect ratio and removing duplicate code in NamingViewController (#141) * - Update SDK * - Exit editing mode in the server list when the user selects an existing or adds a new bookmark (as reported by @mneuwert) * - Adapt app code base to change in OCError Swift conversion (following OCErrorAuthorizationCancelled typo correction) * - Fix #152: if the user cancels OAuth2, an error is no longer shown (and errors are better to read with recent SDK updates) * - Update to latest SDK * - Make ProgressSummarizer only consider Progress objects with descriptions, resolving "ghost" progress bars without any information in them * - Adapt to change of name of OCConnectionIssue to OCIssue * - Update to latest SDK - ConnectionIssueViewController - added option to provide a block to be called when dismissal has finished - normalize code formatting - UIAlertController+OCIssue - added option to provide a completionHandler that's called when the user made a choice - ClientRootViewController - switched issue and alert presentation to use a AsyncSequentialQueue to present them in order and not on top of each other - fixed a bug where a UIViewController that's in the process of being dismissed led to a failure to present alerts and issues * - Make DisplayViewController use OCCoreOptionReturnImmediatelyIfOfflineOrUnavailable and fix a typo (#179) * - Added priority summaries to ProgressSummarizer - Fixed a crash bug in ImageDisplayViewController - Removed core connection status interpretation from ClientQueryViewController - Added core connection status tracking to ClientRootViewController and utilize priority summaries to display offline or server in maintenance mode status messages * - Fix an issue where "Offline." was shortly shown when logging in - Switch to utilizing short connection status descriptions coming straight from the SDK's connection signal providers - Adapt Localizable.strings accordingly * - Add *.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist to .gitignore * - Updated ios-sdk * - Made FileProviderEnumerator use an OCQuery that includes the root item (fixes #203) - Made FileProviderExtension observe the domain property and trigger an initial query of the root directory when none has even been done before (fixes #205) * - Adapted to latest round of nullability additions in the SDK - Fixing potential crash bugs in DisplayHostViewController, ConnectionIssueViewController, SortMethod and others - Update actions - make use of .completed() instead of calling the completionHandler directly - fixing multi-item support for several actions (completionHandler would previously get executed once for every item instead of once) - ClientDirectoryPickerViewController now calls the completinHandler even on cancelation - Cleaned up OCIssue+Extension and OCItem+Extension - Replacing AsyncSequentialQueue with OCAsyncSequentialQueue * - Update SDK * - Updated ios-sdk * - Update ios-sdk with IPC fixes * - Adapt tests to SDK changes (all tests pass) - Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off * - Present cache contents while waiting for a reply from the server - Updated SDK fixing a lot of issues * - Replacing DispatchQueue.main.async* with OnMainThread and a newly added OnMainThread(after: timeInterval) * - Add verbose logging to FileProviderExtension to track the commands received by iOS and the results that were returned * - Temporary workaround: make importFileFromURL: not return directly with the placeholder, but only when upload has completed - and then return the final item * - Switching ios-sdk to updated master branch

@mneuwert

* Added UIViewController extension allowing to swap tabBar for toolbar * Hiding ‘more’ button when cell is configured for edit mode * Laid down the foundation for multi-selection and related actions * Multi-selection works with “Move” and “Delete” actions * Re-added upload button * Exchanging tab-bar with toolbar not animated * Fixed margins for devices with safe area guides (iPhoneX etc.) * Avoiding visual glitches by adding a toolbar in a proper position in the view hierarchy * Showing upload button only when appropriate * exclude app ownCloudTests from lint rules (#186) * Add notification to update version numbers on oc.org/download (#201) * [feature/fp-series-2] File Provider improvements (#167) * - Minor memory optimizations - Updated to latest SDK * - Save changes prior to merge with master * - Convert to Swift 4.2 * - Further Swift 4.2 changes * - Update to latest SDK develop commit * - Adapting APP to latest SDK changes - maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus * - Added back ownCloudUI.framework to copy phase of ownCloud target - Updated to latest SDK * - Add support for OCLogToggle in Settings - App now logs current log settings at launch * - Fix issues in ClientQueryViewController related to UITableView not reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others * - Remove last traces of OCMocking.framework from ownCloud app target, make sure it's only built, linked to and copied in the ownCloudTests target * - Fix EarlGrey/CocoaPods workspace / build errors * - Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension * - Update SDK * - Remove superfluous [FP] from log message * - Make sure DisplayViewController uses the updated version of an item after downloading it instead of the (now) outdated original version * - Update to latest SDK * - Fixing thumbnail aspect ratio and removing duplicate code in NamingViewController (#141) * - Update SDK * - Exit editing mode in the server list when the user selects an existing or adds a new bookmark (as reported by @mneuwert) * - Adapt app code base to change in OCError Swift conversion (following OCErrorAuthorizationCancelled typo correction) * - Fix #152: if the user cancels OAuth2, an error is no longer shown (and errors are better to read with recent SDK updates) * - Update to latest SDK * - Make ProgressSummarizer only consider Progress objects with descriptions, resolving "ghost" progress bars without any information in them * - Adapt to change of name of OCConnectionIssue to OCIssue * - Update to latest SDK - ConnectionIssueViewController - added option to provide a block to be called when dismissal has finished - normalize code formatting - UIAlertController+OCIssue - added option to provide a completionHandler that's called when the user made a choice - ClientRootViewController - switched issue and alert presentation to use a AsyncSequentialQueue to present them in order and not on top of each other - fixed a bug where a UIViewController that's in the process of being dismissed led to a failure to present alerts and issues * - Make DisplayViewController use OCCoreOptionReturnImmediatelyIfOfflineOrUnavailable and fix a typo (#179) * - Added priority summaries to ProgressSummarizer - Fixed a crash bug in ImageDisplayViewController - Removed core connection status interpretation from ClientQueryViewController - Added core connection status tracking to ClientRootViewController and utilize priority summaries to display offline or server in maintenance mode status messages * - Fix an issue where "Offline." was shortly shown when logging in - Switch to utilizing short connection status descriptions coming straight from the SDK's connection signal providers - Adapt Localizable.strings accordingly * - Add *.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist to .gitignore * - Updated ios-sdk * - Made FileProviderEnumerator use an OCQuery that includes the root item (fixes #203) - Made FileProviderExtension observe the domain property and trigger an initial query of the root directory when none has even been done before (fixes #205) * - Adapted to latest round of nullability additions in the SDK - Fixing potential crash bugs in DisplayHostViewController, ConnectionIssueViewController, SortMethod and others - Update actions - make use of .completed() instead of calling the completionHandler directly - fixing multi-item support for several actions (completionHandler would previously get executed once for every item instead of once) - ClientDirectoryPickerViewController now calls the completinHandler even on cancelation - Cleaned up OCIssue+Extension and OCItem+Extension - Replacing AsyncSequentialQueue with OCAsyncSequentialQueue * - Update SDK * - Updated ios-sdk * - Update ios-sdk with IPC fixes * - Adapt tests to SDK changes (all tests pass) - Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off * - Present cache contents while waiting for a reply from the server - Updated SDK fixing a lot of issues * - Replacing DispatchQueue.main.async* with OnMainThread and a newly added OnMainThread(after: timeInterval) * - Add verbose logging to FileProviderExtension to track the commands received by iOS and the results that were returned * - Temporary workaround: make importFileFromURL: not return directly with the placeholder, but only when upload has completed - and then return the final item * - Switching ios-sdk to updated master branch * Version Bump to 99 * [tx] updated from transifex * Added several languages (#231) * Added the languages cs_CZ de de_DE en_GB ko mk nb_NO nn_NO pt_BR pt_PT ru sq th_TH zh_CN * Fixed a compilation issue because CZ file * Updated the commit of the SDK * [tx] updated from transifex * Version Bump to 100 * Copy action (#207) * - Made the Copy action. - Fix some UI Color scheme inconsistencies. * - Made the 'Copy here' button respect the original title * - SDK Update * - Fix for a lint warning * Offline behaviour in Open In Action (#227) * -Add proper message when no connection and user tries to make the open in action * - Localize the error message. * - Made the name of the app to be the app's name in the bundle * - Changed the three dots bar button in the file list to a '+'. (#206) - Made UISegmentedControll to be Themeable. * Version Bump to 101 * [tx] updated from transifex * [tx] updated from transifex * Laid down the foundation for multi-selection and related actions * Multi-selection works with “Move” and “Delete” actions * [feature/fp-series-2] File Provider improvements (#167) * - Minor memory optimizations - Updated to latest SDK * - Save changes prior to merge with master * - Convert to Swift 4.2 * - Further Swift 4.2 changes * - Update to latest SDK develop commit * - Adapting APP to latest SDK changes - maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus * - Added back ownCloudUI.framework to copy phase of ownCloud target - Updated to latest SDK * - Add support for OCLogToggle in Settings - App now logs current log settings at launch * - Fix issues in ClientQueryViewController related to UITableView not reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others * - Remove last traces of OCMocking.framework from ownCloud app target, make sure it's only built, linked to and copied in the ownCloudTests target * - Fix EarlGrey/CocoaPods workspace / build errors * - Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension * - Update SDK * - Remove superfluous [FP] from log message * - Make sure DisplayViewController uses the updated version of an item after downloading it instead of the (now) outdated original version * - Update to latest SDK * - Fixing thumbnail aspect ratio and removing duplicate code in NamingViewController (#141) * - Update SDK * - Exit editing mode in the server list when the user selects an existing or adds a new bookmark (as reported by @mneuwert) * - Adapt app code base to change in OCError Swift conversion (following OCErrorAuthorizationCancelled typo correction) * - Fix #152: if the user cancels OAuth2, an error is no longer shown (and errors are better to read with recent SDK updates) * - Update to latest SDK * - Make ProgressSummarizer only consider Progress objects with descriptions, resolving "ghost" progress bars without any information in them * - Adapt to change of name of OCConnectionIssue to OCIssue * - Update to latest SDK - ConnectionIssueViewController - added option to provide a block to be called when dismissal has finished - normalize code formatting - UIAlertController+OCIssue - added option to provide a completionHandler that's called when the user made a choice - ClientRootViewController - switched issue and alert presentation to use a AsyncSequentialQueue to present them in order and not on top of each other - fixed a bug where a UIViewController that's in the process of being dismissed led to a failure to present alerts and issues * - Make DisplayViewController use OCCoreOptionReturnImmediatelyIfOfflineOrUnavailable and fix a typo (#179) * - Added priority summaries to ProgressSummarizer - Fixed a crash bug in ImageDisplayViewController - Removed core connection status interpretation from ClientQueryViewController - Added core connection status tracking to ClientRootViewController and utilize priority summaries to display offline or server in maintenance mode status messages * - Fix an issue where "Offline." was shortly shown when logging in - Switch to utilizing short connection status descriptions coming straight from the SDK's connection signal providers - Adapt Localizable.strings accordingly * - Add *.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist to .gitignore * - Updated ios-sdk * - Made FileProviderEnumerator use an OCQuery that includes the root item (fixes #203) - Made FileProviderExtension observe the domain property and trigger an initial query of the root directory when none has even been done before (fixes #205) * - Adapted to latest round of nullability additions in the SDK - Fixing potential crash bugs in DisplayHostViewController, ConnectionIssueViewController, SortMethod and others - Update actions - make use of .completed() instead of calling the completionHandler directly - fixing multi-item support for several actions (completionHandler would previously get executed once for every item instead of once) - ClientDirectoryPickerViewController now calls the completinHandler even on cancelation - Cleaned up OCIssue+Extension and OCItem+Extension - Replacing AsyncSequentialQueue with OCAsyncSequentialQueue * - Update SDK * - Updated ios-sdk * - Update ios-sdk with IPC fixes * - Adapt tests to SDK changes (all tests pass) - Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off * - Present cache contents while waiting for a reply from the server - Updated SDK fixing a lot of issues * - Replacing DispatchQueue.main.async* with OnMainThread and a newly added OnMainThread(after: timeInterval) * - Add verbose logging to FileProviderExtension to track the commands received by iOS and the results that were returned * - Temporary workaround: make importFileFromURL: not return directly with the placeholder, but only when upload has completed - and then return the final item * - Switching ios-sdk to updated master branch * - Added th-TH to the .tx config (#241) - Updated the th translations pushed recently to the right folder - Updated the commit of the library * Added the tx link to contribute on trnslations (#245) * Version Bump to 102 * Laid down the foundation for multi-selection and related actions * Multi-selection works with “Move” and “Delete” actions

- Minor memory optimizations - Updated to latest SDK

05ec52e

felix-schwarz force-pushed the feature/fp-series-2 branch from f669ae8 to 05ec52e Compare November 26, 2018 09:38

felix-schwarz added the work in progress label Nov 26, 2018

jesmrec added the feature:filesApp label Nov 26, 2018

jesmrec mentioned this pull request Nov 26, 2018

Files App Refinements #166

Closed

3 tasks

felix-schwarz added 3 commits December 4, 2018 09:45

- Save changes prior to merge with master

49b0785

- Merge remote-tracking branch 'origin/master' into feature/fp-series-2

2d7612d

- Fix Swift Lint warnings in new UI testing code

- Convert to Swift 4.2

43d0494

felix-schwarz added 4 commits December 4, 2018 22:49

- Further Swift 4.2 changes

63798a9

Merge remote-tracking branch 'origin/master' into feature/fp-series-2

c6f8ec9

- Update to latest SDK develop commit

4fe6430

Merge remote-tracking branch 'origin/master' into feature/fp-series-2

267372c

felix-schwarz added 5 commits December 6, 2018 16:44

- Adapting APP to latest SDK changes

d4ce438

- maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus

- Added back ownCloudUI.framework to copy phase of ownCloud target

f89c018

- Updated to latest SDK

- Add support for OCLogToggle in Settings

5a5b824

- App now logs current log settings at launch

- Remove last traces of OCMocking.framework from ownCloud app target,…

14a0b5b

… make sure it's only built, linked to and copied in the ownCloudTests target

- Fix EarlGrey/CocoaPods workspace / build errors

2132b77

felix-schwarz force-pushed the feature/fp-series-2 branch from 91bb032 to 2132b77 Compare December 11, 2018 20:33

felix-schwarz added 3 commits December 12, 2018 16:46

- Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension

334f416

- Update SDK

bcc96a1

- Remove superfluous [FP] from log message

6a5b525

jesmrec assigned jesmrec and felix-schwarz and unassigned jesmrec Jan 18, 2019

jesmrec requested review from mneuwert and hosy January 18, 2019 10:26

felix-schwarz added 5 commits January 18, 2019 11:28

- Adapt tests to SDK changes (all tests pass)

eb5f074

- Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off

- Present cache contents while waiting for a reply from the server

d00a7bc

- Updated SDK fixing a lot of issues

- Replacing DispatchQueue.main.async* with OnMainThread and a newly a…

7ecec80

…dded OnMainThread(after: timeInterval)

Merge remote-tracking branch 'origin/master' into feature/fp-series-2

132eb9d

- Add verbose logging to FileProviderExtension to track the commands …

208733c

…received by iOS and the results that were returned

- Temporary workaround: make importFileFromURL: not return directly w…

6a5581d

…ith the placeholder, but only when upload has completed - and then return the final item

mneuwert approved these changes Jan 22, 2019

View reviewed changes

felix-schwarz added 2 commits January 23, 2019 12:00

- Switching ios-sdk to updated master branch

efe24f4

Merge branch 'master' into feature/fp-series-2

6e6f563

hosy approved these changes Jan 23, 2019

View reviewed changes

jesmrec merged commit 0b19d6d into master Jan 23, 2019

delete-merged-branch bot deleted the feature/fp-series-2 branch January 23, 2019 15:31

felix-schwarz mentioned this pull request Jan 23, 2019

[feature/fp-series-3] File Provider improvements #233

Merged

16 tasks

This was referenced Jan 24, 2019

Cannot fetch directories and app crashes on top-level files when extra trailing slash in server URL. #193

Closed

Fileprovider support for importing bundle documents (Pages/Keynote) #235

Closed

felix-schwarz mentioned this pull request Feb 4, 2019

[feature/fp-series-4] File Provider improvements #253

Merged

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/fp-series-2] File Provider improvements #167

[feature/fp-series-2] File Provider improvements #167

felix-schwarz commented Nov 26, 2018

CLAassistant commented Nov 26, 2018 •

edited

Loading

codecov bot commented Nov 26, 2018 •

edited

Loading

jesmrec commented Nov 26, 2018 •

edited

Loading

kopischke commented Dec 4, 2018

jesmrec commented Dec 4, 2018 •

edited

Loading

kopischke commented Dec 5, 2018 •

edited

Loading

felix-schwarz commented Dec 6, 2018 •

edited

Loading

kopischke commented Dec 11, 2018 •

edited

Loading

jesmrec commented Jan 21, 2019 •

edited

Loading

felix-schwarz commented Jan 22, 2019

felix-schwarz commented Jan 22, 2019

jesmrec commented Jan 22, 2019 •

edited

Loading

felix-schwarz commented Jan 22, 2019

jesmrec commented Jan 22, 2019

mneuwert Jan 22, 2019

felix-schwarz Jan 23, 2019

mneuwert Jan 22, 2019

felix-schwarz Jan 23, 2019

[feature/fp-series-2] File Provider improvements #167

[feature/fp-series-2] File Provider improvements #167

Conversation

felix-schwarz commented Nov 26, 2018

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

CLAassistant commented Nov 26, 2018 • edited Loading

codecov bot commented Nov 26, 2018 • edited Loading

Codecov Report

jesmrec commented Nov 26, 2018 • edited Loading

kopischke commented Dec 4, 2018

jesmrec commented Dec 4, 2018 • edited Loading

kopischke commented Dec 5, 2018 • edited Loading

felix-schwarz commented Dec 6, 2018 • edited Loading

kopischke commented Dec 11, 2018 • edited Loading

jesmrec commented Jan 21, 2019 • edited Loading

felix-schwarz commented Jan 22, 2019

felix-schwarz commented Jan 22, 2019

jesmrec commented Jan 22, 2019 • edited Loading

felix-schwarz commented Jan 22, 2019

jesmrec commented Jan 22, 2019

mneuwert Jan 22, 2019

Choose a reason for hiding this comment

felix-schwarz Jan 23, 2019

Choose a reason for hiding this comment

mneuwert Jan 22, 2019

Choose a reason for hiding this comment

felix-schwarz Jan 23, 2019

Choose a reason for hiding this comment

CLAassistant commented Nov 26, 2018 •

edited

Loading

codecov bot commented Nov 26, 2018 •

edited

Loading

jesmrec commented Nov 26, 2018 •

edited

Loading

jesmrec commented Dec 4, 2018 •

edited

Loading

kopischke commented Dec 5, 2018 •

edited

Loading

felix-schwarz commented Dec 6, 2018 •

edited

Loading

kopischke commented Dec 11, 2018 •

edited

Loading

jesmrec commented Jan 21, 2019 •

edited

Loading

jesmrec commented Jan 22, 2019 •

edited

Loading