Set same behaviour downloading from "Open In" as in regular download when device is offline

[jesmrec]

With no connection:

Clicking on a file to download

"Open In":

• Direct download warn the user he does not have connection
• Open In tries to download forever

Both should have the same behaviour.

[michaelstingl]

After performing "Open in…" whilst being offline, progress bar stays forever in broken state. (see @jesmrec 's #132 (comment) , same in #182)

[felix-schwarz]

This issue can be handled by adding an option to the core's download command.

Providing that option to the download command while offline would make it immediately return with either:

• the file (in case it already exists locally)
• an error (indicating the file can't be downloaded right now)

That way, both the viewer and Open In can provide consistent status information.

@pablocarmu If you agree, I'll add that option as part of the ongoing sync engine work and update this issue as soon as it is available in the SDK repo.

[pablocarmu]

If I understand correctly this would add a new argument (or another kind of parameter/option) to the OCCore's download method to download from server or retrieve the file from cache depending if there's a connection or not.

Something like:

// Please don't take attention to the argument name, it's a dummy one
//
// With connection
core.download(..., fromServer: true, ...)

// Without connection
core.download(..., fromServer: false, ...)

Is this correct?
if this is correct I totally agree

[felix-schwarz]

@pablocarmu I thought of something like this

core.download(..., options: [ OCDownloadOption.returnImmediatelyIfOfflineOrUnavailable : true ], …)

This would behave like this:

• when online: download the item and then return it via the completionHandler
• when offline or in maintenance mode and …
  • … a local copy exists: return the local copy via the completionHandler
  • … no local copy exists: return an error to the completionHandler

[pablocarmu]

works for me!

[felix-schwarz]

The API is available as of ca11f94. Also in there I've changed DisplayViewController to take advantage of the new API to show how it can be used.

[jesmrec]

An alert will show the user that he lacks connection, for this first iteration.