Offline behaviour in Open In Action #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=========================================
Coverage ? 48.92%
=========================================
Files ? 98
Lines ? 8216
Branches ? 0
=========================================
Hits ? 4020
Misses ? 4196
Partials ? 0
Continue to review full report at Codecov.
|
mneuwert
approved these changes
Jan 22, 2019
|
Feature implementation is correct. The detail i noticed is that the |
hosy
approved these changes
Jan 23, 2019
michaelstingl
suggested changes
Jan 23, 2019
There was a problem hiding this comment.
@jesmrec good catch in #227 (comment) !
@pablocarmu Please fix
pablocarmu
force-pushed
the
fix/offline_open_in
branch
from
8ec0e53 to
f54efd5
Compare
|
Fixed and approved |
jesmrec
approved these changes
Jan 24, 2019
pablocarmu
force-pushed
the
fix/offline_open_in
branch
from
f54efd5 to
91c46a0
Compare
mneuwert
pushed a commit
that referenced
this pull request
Jan 31, 2019
* -Add proper message when no connection and user tries to make the open in action * - Localize the error message. * - Made the name of the app to be the app's name in the bundle
jesmrec
pushed a commit
that referenced
this pull request
Feb 1, 2019
* Added UIViewController extension allowing to swap tabBar for toolbar * Hiding ‘more’ button when cell is configured for edit mode * Laid down the foundation for multi-selection and related actions * Multi-selection works with “Move” and “Delete” actions * Re-added upload button * Exchanging tab-bar with toolbar not animated * Fixed margins for devices with safe area guides (iPhoneX etc.) * Avoiding visual glitches by adding a toolbar in a proper position in the view hierarchy * Showing upload button only when appropriate * exclude app ownCloudTests from lint rules (#186) * Add notification to update version numbers on oc.org/download (#201) * [feature/fp-series-2] File Provider improvements (#167) * - Minor memory optimizations - Updated to latest SDK * - Save changes prior to merge with master * - Convert to Swift 4.2 * - Further Swift 4.2 changes * - Update to latest SDK develop commit * - Adapting APP to latest SDK changes - maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus * - Added back ownCloudUI.framework to copy phase of ownCloud target - Updated to latest SDK * - Add support for OCLogToggle in Settings - App now logs current log settings at launch * - Fix issues in ClientQueryViewController related to UITableView not reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others * - Remove last traces of OCMocking.framework from ownCloud app target, make sure it's only built, linked to and copied in the ownCloudTests target * - Fix EarlGrey/CocoaPods workspace / build errors * - Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension * - Update SDK * - Remove superfluous [FP] from log message * - Make sure DisplayViewController uses the updated version of an item after downloading it instead of the (now) outdated original version * - Update to latest SDK * - Fixing thumbnail aspect ratio and removing duplicate code in NamingViewController (#141) * - Update SDK * - Exit editing mode in the server list when the user selects an existing or adds a new bookmark (as reported by @mneuwert) * - Adapt app code base to change in OCError Swift conversion (following OCErrorAuthorizationCancelled typo correction) * - Fix #152: if the user cancels OAuth2, an error is no longer shown (and errors are better to read with recent SDK updates) * - Update to latest SDK * - Make ProgressSummarizer only consider Progress objects with descriptions, resolving "ghost" progress bars without any information in them * - Adapt to change of name of OCConnectionIssue to OCIssue * - Update to latest SDK - ConnectionIssueViewController - added option to provide a block to be called when dismissal has finished - normalize code formatting - UIAlertController+OCIssue - added option to provide a completionHandler that's called when the user made a choice - ClientRootViewController - switched issue and alert presentation to use a AsyncSequentialQueue to present them in order and not on top of each other - fixed a bug where a UIViewController that's in the process of being dismissed led to a failure to present alerts and issues * - Make DisplayViewController use OCCoreOptionReturnImmediatelyIfOfflineOrUnavailable and fix a typo (#179) * - Added priority summaries to ProgressSummarizer - Fixed a crash bug in ImageDisplayViewController - Removed core connection status interpretation from ClientQueryViewController - Added core connection status tracking to ClientRootViewController and utilize priority summaries to display offline or server in maintenance mode status messages * - Fix an issue where "Offline." was shortly shown when logging in - Switch to utilizing short connection status descriptions coming straight from the SDK's connection signal providers - Adapt Localizable.strings accordingly * - Add *.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist to .gitignore * - Updated ios-sdk * - Made FileProviderEnumerator use an OCQuery that includes the root item (fixes #203) - Made FileProviderExtension observe the domain property and trigger an initial query of the root directory when none has even been done before (fixes #205) * - Adapted to latest round of nullability additions in the SDK - Fixing potential crash bugs in DisplayHostViewController, ConnectionIssueViewController, SortMethod and others - Update actions - make use of .completed() instead of calling the completionHandler directly - fixing multi-item support for several actions (completionHandler would previously get executed once for every item instead of once) - ClientDirectoryPickerViewController now calls the completinHandler even on cancelation - Cleaned up OCIssue+Extension and OCItem+Extension - Replacing AsyncSequentialQueue with OCAsyncSequentialQueue * - Update SDK * - Updated ios-sdk * - Update ios-sdk with IPC fixes * - Adapt tests to SDK changes (all tests pass) - Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off * - Present cache contents while waiting for a reply from the server - Updated SDK fixing a lot of issues * - Replacing DispatchQueue.main.async* with OnMainThread and a newly added OnMainThread(after: timeInterval) * - Add verbose logging to FileProviderExtension to track the commands received by iOS and the results that were returned * - Temporary workaround: make importFileFromURL: not return directly with the placeholder, but only when upload has completed - and then return the final item * - Switching ios-sdk to updated master branch * Version Bump to 99 * [tx] updated from transifex * Added several languages (#231) * Added the languages cs_CZ de de_DE en_GB ko mk nb_NO nn_NO pt_BR pt_PT ru sq th_TH zh_CN * Fixed a compilation issue because CZ file * Updated the commit of the SDK * [tx] updated from transifex * Version Bump to 100 * Copy action (#207) * - Made the Copy action. - Fix some UI Color scheme inconsistencies. * - Made the 'Copy here' button respect the original title * - SDK Update * - Fix for a lint warning * Offline behaviour in Open In Action (#227) * -Add proper message when no connection and user tries to make the open in action * - Localize the error message. * - Made the name of the app to be the app's name in the bundle * - Changed the three dots bar button in the file list to a '+'. (#206) - Made UISegmentedControll to be Themeable. * Version Bump to 101 * [tx] updated from transifex * [tx] updated from transifex * Laid down the foundation for multi-selection and related actions * Multi-selection works with “Move” and “Delete” actions * [feature/fp-series-2] File Provider improvements (#167) * - Minor memory optimizations - Updated to latest SDK * - Save changes prior to merge with master * - Convert to Swift 4.2 * - Further Swift 4.2 changes * - Update to latest SDK develop commit * - Adapting APP to latest SDK changes - maintenance mode support - replacing uses of reachability monitor with OCCore.connectionStatus * - Added back ownCloudUI.framework to copy phase of ownCloud target - Updated to latest SDK * - Add support for OCLogToggle in Settings - App now logs current log settings at launch * - Fix issues in ClientQueryViewController related to UITableView not reloading when its view controller is not "visible": - no longer uses items from table view cells to initiate actions - detects if UITableView.reloadData is set to do nothing and repeats the call in viewWillAppear - The fixed issue was causing #178 and possibly others * - Remove last traces of OCMocking.framework from ownCloud app target, make sure it's only built, linked to and copied in the ownCloudTests target * - Fix EarlGrey/CocoaPods workspace / build errors * - Adopt new OCLogger tags APIs in Log.swift and FileProviderExtension * - Update SDK * - Remove superfluous [FP] from log message * - Make sure DisplayViewController uses the updated version of an item after downloading it instead of the (now) outdated original version * - Update to latest SDK * - Fixing thumbnail aspect ratio and removing duplicate code in NamingViewController (#141) * - Update SDK * - Exit editing mode in the server list when the user selects an existing or adds a new bookmark (as reported by @mneuwert) * - Adapt app code base to change in OCError Swift conversion (following OCErrorAuthorizationCancelled typo correction) * - Fix #152: if the user cancels OAuth2, an error is no longer shown (and errors are better to read with recent SDK updates) * - Update to latest SDK * - Make ProgressSummarizer only consider Progress objects with descriptions, resolving "ghost" progress bars without any information in them * - Adapt to change of name of OCConnectionIssue to OCIssue * - Update to latest SDK - ConnectionIssueViewController - added option to provide a block to be called when dismissal has finished - normalize code formatting - UIAlertController+OCIssue - added option to provide a completionHandler that's called when the user made a choice - ClientRootViewController - switched issue and alert presentation to use a AsyncSequentialQueue to present them in order and not on top of each other - fixed a bug where a UIViewController that's in the process of being dismissed led to a failure to present alerts and issues * - Make DisplayViewController use OCCoreOptionReturnImmediatelyIfOfflineOrUnavailable and fix a typo (#179) * - Added priority summaries to ProgressSummarizer - Fixed a crash bug in ImageDisplayViewController - Removed core connection status interpretation from ClientQueryViewController - Added core connection status tracking to ClientRootViewController and utilize priority summaries to display offline or server in maintenance mode status messages * - Fix an issue where "Offline." was shortly shown when logging in - Switch to utilizing short connection status descriptions coming straight from the SDK's connection signal providers - Adapt Localizable.strings accordingly * - Add *.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist to .gitignore * - Updated ios-sdk * - Made FileProviderEnumerator use an OCQuery that includes the root item (fixes #203) - Made FileProviderExtension observe the domain property and trigger an initial query of the root directory when none has even been done before (fixes #205) * - Adapted to latest round of nullability additions in the SDK - Fixing potential crash bugs in DisplayHostViewController, ConnectionIssueViewController, SortMethod and others - Update actions - make use of .completed() instead of calling the completionHandler directly - fixing multi-item support for several actions (completionHandler would previously get executed once for every item instead of once) - ClientDirectoryPickerViewController now calls the completinHandler even on cancelation - Cleaned up OCIssue+Extension and OCItem+Extension - Replacing AsyncSequentialQueue with OCAsyncSequentialQueue * - Update SDK * - Updated ios-sdk * - Update ios-sdk with IPC fixes * - Adapt tests to SDK changes (all tests pass) - Stop CocoaPods from sending statistics by adding a line to the Podfile turning this off * - Present cache contents while waiting for a reply from the server - Updated SDK fixing a lot of issues * - Replacing DispatchQueue.main.async* with OnMainThread and a newly added OnMainThread(after: timeInterval) * - Add verbose logging to FileProviderExtension to track the commands received by iOS and the results that were returned * - Temporary workaround: make importFileFromURL: not return directly with the placeholder, but only when upload has completed - and then return the final item * - Switching ios-sdk to updated master branch * - Added th-TH to the .tx config (#241) - Updated the th translations pushed recently to the right folder - Updated the commit of the library * Added the tx link to contribute on trnslations (#245) * Version Bump to 102 * Laid down the foundation for multi-selection and related actions * Multi-selection works with “Move” and “Delete” actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #179
Related Issue
#179
Types of changes
Checklist: