[feature/fp-series-4] File Provider improvements #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
felix-schwarz
changed the title
8Rename + Duplicate in files app not working as expected when the server in maintenance mode (likely in whole offline mode) Steps:
Tested with commit |
felix-schwarz
force-pushed
the
feature/fp-series-4
branch
from
0bd0782 to
c47d51e
Compare
|
Update with commit c47d51e:
Still Reproducible: (1), (4), (5), (7), (8) Batched uploads: #224 |
(9)Check this steps out:
Current: app is stucked Commit: c47d51e |
- Updated BookmarkViewController for leaner OCConnection init - Streamline ClientItemCell UI update code
- Fix SwiftLint warning
- Use OCHTTPPipelineManager.setupPersistentPipelines to keep pipelines open for the lifetime of the process - Add missing completionHandler calls for OCCoreManager scheduleOfflineOperation calls (!)
- use of NSFileProtectionCompleteUntilFirstUserAuthentication in FileProvider - Renaming "Activity" tab to "Status" - drew and added new icon "status-flash" - Update to latest ios-sdk
|
@jesmrec Ready for QA:
This is a OS level bug. Copy and pasting of folders is as broken as folder duplication. But we can't detect and block it in this case, unfortunately:
Please see the log excerpt in Appendix A to see the commands iOS sends to the File Provider.
Likely an issue with the previous OCCoreManager implementation dead-locking or OCCore locking on shutdown. Both known issues have been addressed. I could not reproduce this issue.
Cancellation is now only available for those sync actions that have support for it (currently upload and download), so issue 4 no longer applies.
The cancellation is stored as an event, but only processed when the operation's sync record's time has come. So if you upload a large file and then trigger a download, then cancel the download, then cancel the upload, the download will not take place. Improved cancellation support is part of the full implementation of offline support.
This should have been fixed for a while. FWIW I could not reproduce this.
This is also subject to implementing full offline support.
I could not reproduce this direc, but found another issue, which I fixed. The way it should work now is that an alert comes up saying that the file has changed on the server - and whether the user really wants to delete the file. That alert is triggered by the server responding with Appendix A |
This was referenced Feb 22, 2019
Closed
Open
|
Checks with 77cd2c0 (1), (2), (3), (4), (6), (7), (9) -> fixed (8) -> addressed to offline About (4) and (5)
i guess you mean cancellation for enqueued operations, not for the current executing one. Apart of the technical explanation about the sync record (thanks!), the point is that the user should not see a "stop" button that is not clickable. So, i'd extend the non-availability condition for cancellations to every enqueued action, included uploads and downloads. We will iterate to improve this.
for me, this behaviour is the expected. you cancelled the enqueued action, so it will not take place after the current one finishes or is cancelled. |
…/ios-app into feature/fp-series-4
…nitions to OCCoreManager changes
hosy
approved these changes
Feb 26, 2019
mneuwert
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further improvements to the file provider
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Status check:
ios-app/ownCloudTests/Login/EditBookmarkTests.swift
Line 85 in efe24f4
BUGS & IMPROVEMENTS