Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot fetch directories and app crashes on top-level files when extra trailing slash in server URL. #193

Closed
risacher opened this issue Dec 23, 2018 · 7 comments
Assignees
Labels
fixed-in-branch p2-high Escalation, on top of current planning, release blocker sdk-involved Requires SDK development or discussion Type:bug Something isn't working
Milestone

Comments

@risacher
Copy link

Steps to reproduce

  1. Connect app to server with extra trailing slash in the URL - ie. "https://FQDN/owncloud//"
  2. Try to fetch any directory or file

Expected behaviour

Tell us what should happen

Show directory content or file

Actual behaviour

Tell us what happens instead

All directories show "Folder Removed" error, "This folder no longer exists on the server."

Inspection of network traffic indicates that the app is attempting to GET the following path: "/owncloud//remote.php/dav/files/dan/owncloud/remote.php/dav/files/dan/documents/"

Attempting to open a file from the root directory crashes the app.

Client

iOS version:

12.0.1

ownCloud app version:

Beta 1.0 Build 85

Device model:

iPhone S

Server configuration

Web server:

Apache2 behind custom reverse-proxy

Database:
sqlite3

PHP version:

7.0, I think

ownCloud version:

10.0.9.5

Storage backend (external storage):

n/a

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

Insert your ownCloud log here

Tell us what could be improved:

@risacher
Copy link
Author

Alternatively, the iOS app should either delete the extra slash or give error message. But it connects and can fetch the top-level directory okay, which made it hard to figure out why it wasn't working.

@risacher risacher changed the title Cannot fetch directories and app crashes on top-level files when extra trailing slash in path. Cannot fetch directories and app crashes on top-level files when extra trailing slash in server URL. Dec 23, 2018
@michaelstingl michaelstingl added Type:bug Something isn't working p2-high Escalation, on top of current planning, release blocker sdk-involved Requires SDK development or discussion labels Dec 24, 2018
@michaelstingl michaelstingl added this to the 0.4.0 milestone Dec 24, 2018
@jesmrec jesmrec self-assigned this Jan 11, 2019
@felix-schwarz
Copy link
Contributor

felix-schwarz commented Jan 15, 2019

Thanks for reporting this issue @risacher!

The issue should be fixed as of 3266cfa (and in an upcoming TestFlight build that will be part of).

@jesmrec
Copy link
Contributor

jesmrec commented Jan 22, 2019

@risacher did you check with a newer build?

@michaelstingl
Copy link
Contributor

@risacher did you check with a newer build?

didn't published a new build on TestFlight. sorry

@jesmrec
Copy link
Contributor

jesmrec commented Jan 22, 2019

ok, i will try to get a server with double slash... with subfolder is easy to build, i will check other options.

@jesmrec
Copy link
Contributor

jesmrec commented Jan 24, 2019

The fix is already merged inside #167. Let's wait for additional feedback before closing.

@risacher
Copy link
Author

I just tested with TestFlight build and seems fixed to me.

https://myserver.org/owncloud// is changed to https://myserver.org/owncloud/ and then works.

interestingly, extra slashes internally (e.g. https://myserver.org//owncloud/) just "work". (Unsurprisingly, since the web server ignores these.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-branch p2-high Escalation, on top of current planning, release blocker sdk-involved Requires SDK development or discussion Type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants