Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump doctrine/dbal from 2.6.3 to 2.7.1 #31059

Merged
merged 2 commits into from
Apr 19, 2018

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 9, 2018

Bumps doctrine/dbal from 2.6.3 to 2.7.1.

Release notes

Sourced from doctrine/dbal's releases.

v2.7.1

Release v2.7.1

Build Status

This release fixes unintentional BC breaks:

  1. It was impossible to use deprecated fetch modes with PDO-based drivers.
  2. An unsupported option passed to the Column object prevented subsequent options from being applied.
  3. Date interval values stored prior to upgrade to v2.7.0 were reported as invalid.

Total issues resolved: 10

Backwards Compatibility Fixes:

Documentation Improvements:

Continuous Integration Improvements:

v2.7.0

Build Status

This is a minor release of Doctrine DBAL that aggregates over 80 fixes and improvements developed over the last 8 months.

This release includes all changes of the 2.6.x series, as well as feature additions and improvements that couldn't land in patch releases.

Backwards Compatibility Breaks

This release comes with one potential Backwards Compatibility (BC) break that is to be considered during upgrade.
Please see the details below.

Dependency requirement changes

There are no changes in requirements to runtime dependencies.

Deprecations

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: Dependabot was ignoring updates to this dependency, but since you've updated it yourself we've started tracking it for you again. 🤖

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot ignore this [minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use [this|these] label[s] will set the current labels as the default for future PRs for this repo and language

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #31059 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31059      +/-   ##
============================================
+ Coverage      62.5%   62.53%   +0.02%     
+ Complexity    18270    18263       -7     
============================================
  Files          1146     1146              
  Lines         68398    68443      +45     
  Branches       1234     1234              
============================================
+ Hits          42754    42802      +48     
+ Misses        25283    25280       -3     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (+0.02%) 0 <ø> (ø) ⬇️
#phpunit 63.73% <ø> (+0.02%) 18263 <ø> (-7) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/ConnectionFactory.php 82.19% <ø> (-0.71%) 20 <0> (-1)
apps/files/lib/Service/TagService.php 95% <0%> (-5%) 6% <0%> (+1%)
apps/files/lib/AppInfo/Application.php 39.02% <0%> (-0.98%) 7% <0%> (-1%)
lib/private/PreviewManager.php 50% <0%> (-0.77%) 50% <0%> (+1%)
core/templates/lostpassword/email.php 100% <0%> (ø) 0% <0%> (ø) ⬇️
index.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
core/ajax/share.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
core/templates/lostpassword/altemail.php 100% <0%> (ø) 0% <0%> (?)
lib/private/Server.php 85.05% <0%> (+0.03%) 254% <0%> (ø) ⬇️
lib/private/SubAdmin.php 99.18% <0%> (+0.05%) 26% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0536e6...039b8cc. Read the comment docs.

@DeepDiver1975
Copy link
Member

@VicDeo Can you please have a look why these lines are no longer hit with postgres? I assume this is because the fix is upstream available now? Please confirm - THX

https://codecov.io/gh/owncloud/core/compare/c7c8b5e0489ebc4cd23213cfcdc3d2d79153d048...da01bedf91651e86c38c13310ca51d943213b288/src/lib/private/DB/OCPostgreSqlPlatform.php

@DeepDiver1975 DeepDiver1975 added this to the development milestone Apr 10, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Apr 10, 2018
@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/doctrine/dbal-2.7.1 branch from da01bed to 34ffc62 Compare April 12, 2018 09:16
@VicDeo
Copy link
Member

VicDeo commented Apr 14, 2018

@DeepDiver1975 yes, both issues with altering table from int to bigint for postgre was fixed in 2.6.4 with doctrine/dbal#2916

907bfa3 and 20fa3f0 could be reverted while bumping to 2.7.1

@DeepDiver1975
Copy link
Member

THX
Can you please revert the commits in here?

@DeepDiver1975 DeepDiver1975 merged commit 23eea00 into master Apr 19, 2018
@DeepDiver1975 DeepDiver1975 deleted the dependabot/composer/doctrine/dbal-2.7.1 branch April 19, 2018 06:52
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@phil-davis
Copy link
Contributor

Needs to be backported to stable10 as part of "drop PHP7.0" and "support pgsql 10.3"
Currently waiting in PR #35786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants